tools/testing/dart/android.dart - Issue 218683009: test.dart: Add timeout for browsers that are started but do not fetch tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/android.dart

Issue 218683009: test.dart: Add timeout for browsers that are started but do not fetch tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add null check. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/android.dart

diff --git a/tools/testing/dart/android.dart b/tools/testing/dart/android.dart

index 6a2fc4a0bd20e572da40119d903e6e401c3156e4..54d56baf56bd251851f09a72ddc9fb49661b50ef 100644

--- a/tools/testing/dart/android.dart

+++ b/tools/testing/dart/android.dart

@@ -57,6 +57,8 @@ Future _executeCommandRaw(String executable,

"stderr: \n ${results[1]}"

"exitCode: \n ${results[2]}";

throw new Exception(error);

+ } else {

+ DebugLogger.info("Success: $executable finished");

}

return results[0];

});

@@ -299,7 +301,7 @@ class AdbDevice {

}

/**

- * Helper to list all adb devicess available.

+ * Helper to list all adb devices available.

class AdbHelper {

static RegExp _deviceLineRegexp =

« no previous file with comments | « no previous file | tools/testing/dart/browser_controller.dart » ('j') | tools/testing/dart/browser_controller.dart » ('J')