Issue 218683007: Copy stack until safepoint *before* notifying other threads at safepoints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218683007: Copy stack until safepoint before notifying other threads at safepoints. (Closed)

Created:
6 years, 8 months ago by Mads Ager (chromium)

Modified:
6 years, 8 months ago

Reviewers:
haraken, Vyacheslav Egorov (Chromium), wibling-chromium

CC:
blink-reviews, kouhei+heap_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Copy stack until safepoint *before* notifying other threads at safepoints. R=vegorov@chromium.org BUG=356118 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170528

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/heap/ThreadState.cpp	View		2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 8 (0 generated)

haraken

LGTM. Did this cause any actual bug? Or did you notice it since you were ...

6 years, 8 months ago (2014-04-01 06:49:59 UTC) #2

Mads Ager (chromium)

On 2014/04/01 06:49:59, haraken wrote: > LGTM. > > Did this cause any actual bug? ...

6 years, 8 months ago (2014-04-01 06:56:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/218683007/1

6 years, 8 months ago (2014-04-01 06:56:36 UTC) #6

Message was sent while issue was closed.

LGTM