third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h - Issue 2186823002: Do not call an event listener on a cloned node in svg <use>'s UA shadow tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h

Issue 2186823002: Do not call an event listener on a cloned node in svg <use>'s UA shadow tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: skip timeout test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/use-instanceRoot-event-listener-liveness.xhtml ('k') | third_party/WebKit/Source/core/events/Event.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h

index 576e9c0ffff2f223818959b4d29468b9b385660a..59e8997455a02651ba6c2ecac7c32c9ac0eb6705 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h

@@ -66,12 +66,6 @@ private:

v8::Local<v8::Value> callListenerFunction(ScriptState*, v8::Local<v8::Value>, Event*) override;

- // Needs to return true for all event handlers implemented in JavaScript so that

- // the SVG code does not add the event handler in both

- // SVGUseElement::buildShadowTree and again in

- // SVGUseElement::transferEventListenersToShadowTree

- bool wasCreatedFromMarkup() const override { return true; }

void compileScript(ScriptState*, ExecutionContext*);

void fireErrorEvent(v8::Local<v8::Context>, ExecutionContext*, v8::Local<v8::Message>);