predictors: Remove the HTTP restriction for speculative prefetch.

predictors: Remove the HTTP restriction for speculative prefetch.

The prefetcher skips the HTTPS main pages and subresources, which is
unfortunate as more and more pages and resources are served over HTTPS.

Example from loading the verge with this patch, (from
prefetch_predictor_tool.py) on Android:

https://cdn0.vox-cdn.com/stylesheets/verge2_all.v7ffc13f1b68c7dbd.css
https://cdn0.vox-cdn.com/javascripts/libraries.vc262b07aa2474684.js
https://cdn0.vox-cdn.com/javascripts/lib/advertisement.v6fdc11c.js
https://optimize-stats.voxmedia.com/loader.min.js?key=efd28c71b5699c36
https://cdn0.vox-cdn.com/javascripts/verge2_head.v43436e3cdcad9833.js
http://ad-cdn.technoratimedia.com/smartwrapper/81065/1027/sw.min.js
https://www.googletagservices.com/tag/js/gpt.js
https://cdn0.vox-cdn.com/javascripts/verge2_body.v9f33e9e87ec93cd8.js

Without:

http://ad-cdn.technoratimedia.com/smartwrapper/81065/1027/sw.min.js
http://partner.googleadservices.com/gpt/pubads_impl_92.js
http://cdn.yldbt.com/js/yieldbot.intent.js
http://ads.rubiconproject.com/header/7470.js
http://sbnationbidder-d.openx.net/w/1.0/jstag?nc=172968584-theverge1
http://cdn.krxd.net/ctjs/controltag.js.726d287890a4d2c520d4a7a450e210ea
http://www.google-analytics.com/analytics.js
http://pagead2.googlesyndication.com/pagead/osd.js

BUG=631966
Committed: https://crrev.com/c9c483d3058976b76c1c5b4deb3047db140d89cf
Cr-Commit-Position: refs/heads/master@{#408139}

[Benoit L, 2016-07-27 12:38:16]

lizeb@chromium.org changed reviewers:
+ pasko@chromium.org

[pasko, 2016-07-27 14:06:24]

https://codereview.chromium.org/2186803004/diff/20001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_predictor.cc (right):

https://codereview.chromium.org/2186803004/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_predictor.cc:235: return true;
we agreed offline that we should explicitly accept only http and https, for
extra safety

[Benoit L, 2016-07-27 14:25:56]

Thanks!
Done.

https://codereview.chromium.org/2186803004/diff/20001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetch_predictor.cc (right):

https://codereview.chromium.org/2186803004/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetch_predictor.cc:235: return true;
On 2016/07/27 14:06:24, pasko wrote:
> we agreed offline that we should explicitly accept only http and https, for
> extra safety

Done.

[Benoit L, 2016-07-27 14:26:41]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 14:26:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 15:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 15:05:57]

Dry run: This issue passed the CQ dry run.

[pasko, 2016-07-27 15:25:28]

can you please cover this in resource_prefetch_predictor_unittest.cc?

[pasko, 2016-07-27 15:49:57]

lgtm

On 2016/07/27 15:25:28, pasko wrote:
> can you please cover this in resource_prefetch_predictor_unittest.cc?

as per offline discussion, it seems testing this would require to factor out
this one line and call only that, because the rest requires providing more
things to the test, like proper ResourceRequestInfo.

[Benoit L, 2016-07-27 15:52:34]

The CQ bit was checked by lizeb@chromium.org

[commit-bot: I haz the power, 2016-07-27 15:52:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 15:56:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-27 15:57:32]

Description was changed from

==========
predictors: Remove the HTTP restriction for speculative prefetch.

The prefetcher skips the HTTPS main pages and subresources, which is
unfortunate as more and more pages and resources are served over HTTPS.

Example from loading the verge with this patch, (from
prefetch_predictor_tool.py) on Android:

https://cdn0.vox-cdn.com/stylesheets/verge2_all.v7ffc13f1b68c7dbd.css
https://cdn0.vox-cdn.com/javascripts/libraries.vc262b07aa2474684.js
https://cdn0.vox-cdn.com/javascripts/lib/advertisement.v6fdc11c.js
https://optimize-stats.voxmedia.com/loader.min.js?key=efd28c71b5699c36
https://cdn0.vox-cdn.com/javascripts/verge2_head.v43436e3cdcad9833.js
http://ad-cdn.technoratimedia.com/smartwrapper/81065/1027/sw.min.js
https://www.googletagservices.com/tag/js/gpt.js
https://cdn0.vox-cdn.com/javascripts/verge2_body.v9f33e9e87ec93cd8.js

Without:

http://ad-cdn.technoratimedia.com/smartwrapper/81065/1027/sw.min.js
http://partner.googleadservices.com/gpt/pubads_impl_92.js
http://cdn.yldbt.com/js/yieldbot.intent.js
http://ads.rubiconproject.com/header/7470.js
http://sbnationbidder-d.openx.net/w/1.0/jstag?nc=172968584-theverge1
http://cdn.krxd.net/ctjs/controltag.js.726d287890a4d2c520d4a7a450e210ea
http://www.google-analytics.com/analytics.js
http://pagead2.googlesyndication.com/pagead/osd.js

BUG=631966
==========

to

==========
predictors: Remove the HTTP restriction for speculative prefetch.

The prefetcher skips the HTTPS main pages and subresources, which is
unfortunate as more and more pages and resources are served over HTTPS.

Example from loading the verge with this patch, (from
prefetch_predictor_tool.py) on Android:

https://cdn0.vox-cdn.com/stylesheets/verge2_all.v7ffc13f1b68c7dbd.css
https://cdn0.vox-cdn.com/javascripts/libraries.vc262b07aa2474684.js
https://cdn0.vox-cdn.com/javascripts/lib/advertisement.v6fdc11c.js
https://optimize-stats.voxmedia.com/loader.min.js?key=efd28c71b5699c36
https://cdn0.vox-cdn.com/javascripts/verge2_head.v43436e3cdcad9833.js
http://ad-cdn.technoratimedia.com/smartwrapper/81065/1027/sw.min.js
https://www.googletagservices.com/tag/js/gpt.js
https://cdn0.vox-cdn.com/javascripts/verge2_body.v9f33e9e87ec93cd8.js

Without:

http://ad-cdn.technoratimedia.com/smartwrapper/81065/1027/sw.min.js
http://partner.googleadservices.com/gpt/pubads_impl_92.js
http://cdn.yldbt.com/js/yieldbot.intent.js
http://ads.rubiconproject.com/header/7470.js
http://sbnationbidder-d.openx.net/w/1.0/jstag?nc=172968584-theverge1
http://cdn.krxd.net/ctjs/controltag.js.726d287890a4d2c520d4a7a450e210ea
http://www.google-analytics.com/analytics.js
http://pagead2.googlesyndication.com/pagead/osd.js

BUG=631966

Committed: https://crrev.com/c9c483d3058976b76c1c5b4deb3047db140d89cf
Cr-Commit-Position: refs/heads/master@{#408139}
==========

[commit-bot: I haz the power, 2016-07-27 15:57:33]

Patchset 3 (id:??) landed as
https://crrev.com/c9c483d3058976b76c1c5b4deb3047db140d89cf
Cr-Commit-Position: refs/heads/master@{#408139}