Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: components/precache/content/precache_manager_unittest.cc

Issue 2186803003: Add UMA Precache.CacheStatus.NonPrefetch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed PrecacheManagerTests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/precache/core/precache_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/precache/content/precache_manager_unittest.cc
diff --git a/components/precache/content/precache_manager_unittest.cc b/components/precache/content/precache_manager_unittest.cc
index 247d559bbc285199b36519076b8c5c750d48c544..8d24007711824aa7893cae747e6413999e58238c 100644
--- a/components/precache/content/precache_manager_unittest.cc
+++ b/components/precache/content/precache_manager_unittest.cc
@@ -47,7 +47,6 @@ namespace {
using ::testing::_;
using ::testing::ContainerEq;
-using ::testing::ElementsAre;
using ::testing::UnorderedElementsAre;
using ::testing::Invoke;
using ::testing::IsEmpty;
@@ -416,9 +415,11 @@ TEST_F(PrecacheManagerTest, RecordStatsForFetchHTTP) {
base::RunLoop().RunUntilIdle();
EXPECT_THAT(histograms_.GetTotalCountsForPrefix("Precache."),
- ElementsAre(Pair("Precache.DownloadedNonPrecache", 1),
- Pair("Precache.Latency.NonPrefetch", 1),
- Pair("Precache.Latency.NonPrefetch.NonTopHosts", 1)));
+ UnorderedElementsAre(
+ Pair("Precache.DownloadedNonPrecache", 1),
+ Pair("Precache.CacheStatus.NonPrefetch", 1),
+ Pair("Precache.Latency.NonPrefetch", 1),
+ Pair("Precache.Latency.NonPrefetch.NonTopHosts", 1)));
}
TEST_F(PrecacheManagerTest, RecordStatsForFetchHTTPS) {
@@ -428,9 +429,11 @@ TEST_F(PrecacheManagerTest, RecordStatsForFetchHTTPS) {
base::RunLoop().RunUntilIdle();
EXPECT_THAT(histograms_.GetTotalCountsForPrefix("Precache."),
- ElementsAre(Pair("Precache.DownloadedNonPrecache", 1),
- Pair("Precache.Latency.NonPrefetch", 1),
- Pair("Precache.Latency.NonPrefetch.NonTopHosts", 1)));
+ UnorderedElementsAre(
+ Pair("Precache.DownloadedNonPrecache", 1),
+ Pair("Precache.CacheStatus.NonPrefetch", 1),
+ Pair("Precache.Latency.NonPrefetch", 1),
+ Pair("Precache.Latency.NonPrefetch.NonTopHosts", 1)));
}
TEST_F(PrecacheManagerTest, RecordStatsForFetchInTopHosts) {
@@ -445,10 +448,12 @@ TEST_F(PrecacheManagerTest, RecordStatsForFetchInTopHosts) {
base::TimeDelta(), base::Time(), info_, 1000);
base::RunLoop().RunUntilIdle();
- EXPECT_THAT(histograms_.GetTotalCountsForPrefix("Precache."),
- ElementsAre(Pair("Precache.DownloadedNonPrecache", 1),
- Pair("Precache.Latency.NonPrefetch", 1),
- Pair("Precache.Latency.NonPrefetch.TopHosts", 1)));
+ EXPECT_THAT(
+ histograms_.GetTotalCountsForPrefix("Precache."),
+ UnorderedElementsAre(Pair("Precache.DownloadedNonPrecache", 1),
+ Pair("Precache.CacheStatus.NonPrefetch", 1),
+ Pair("Precache.Latency.NonPrefetch", 1),
+ Pair("Precache.Latency.NonPrefetch.TopHosts", 1)));
}
TEST_F(PrecacheManagerTest, DeleteExpiredPrecacheHistory) {
@@ -518,6 +523,7 @@ TEST_F(PrecacheManagerTest, DeleteExpiredPrecacheHistory) {
base::TimeDelta(), kCurrentTime, info_,
1000);
expected_histogram_count_map["Precache.Fetch.TimeToComplete"]++;
+ expected_histogram_count_map["Precache.CacheStatus.NonPrefetch"]++;
expected_histogram_count_map["Precache.Latency.NonPrefetch"]++;
expected_histogram_count_map["Precache.Latency.NonPrefetch.NonTopHosts"]++;
expected_histogram_count_map["Precache.TimeSinceLastPrecache"] += 1;
@@ -534,6 +540,7 @@ TEST_F(PrecacheManagerTest, DeleteExpiredPrecacheHistory) {
precache_manager_->RecordStatsForFetch(GURL("http://yesterday-fetch.com"),
GURL(), base::TimeDelta(),
kCurrentTime, info_, 1000);
+ expected_histogram_count_map["Precache.CacheStatus.NonPrefetch"] += 2;
expected_histogram_count_map["Precache.Latency.NonPrefetch"] += 2;
expected_histogram_count_map["Precache.Latency.NonPrefetch.NonTopHosts"] += 2;
expected_histogram_count_map["Precache.Saved"] += 2;
« no previous file with comments | « no previous file | components/precache/core/precache_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698