third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html - Issue 2186753002: [DevTools] Track URL through the target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html

Issue 2186753002: [DevTools] Track URL through the target (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js ('k') | third_party/WebKit/LayoutTests/inspector/components/linkifier.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html

diff --git a/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html b/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html

index 7445b61a43ebd93840672280445c4a38922ecc5e..02d39bb6998d11c9f89c61eccc10f29b211f945d 100644

--- a/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html

+++ b/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/linkifier.html

@@ -46,13 +46,13 @@ function test()

var scripts = InspectorTest.debuggerModel.scripts;

for (var scriptId in scripts) {

var scriptCandidate = scripts[scriptId];

- if (scriptCandidate.sourceURL === InspectorTest.resourceTreeModel.inspectedPageURL() && scriptCandidate.lineOffset === 4) {

+ if (scriptCandidate.sourceURL === InspectorTest.mainTarget.inspectedURL() && scriptCandidate.lineOffset === 4) {

script = scriptCandidate;

break;

}

- uiSourceCode = WebInspector.workspace.uiSourceCodeForURL(InspectorTest.resourceTreeModel.inspectedPageURL());

+ uiSourceCode = WebInspector.workspace.uiSourceCodeForURL(InspectorTest.mainTarget.inspectedURL());

var linkifyMe = "at triggerError (http://localhost/show/:22:11)";

var fragment = WebInspector.linkifyStringAsFragment(linkifyMe);

var anchor = fragment.querySelector('a');

@@ -62,7 +62,7 @@ function test()

linkifier = new WebInspector.Linkifier();

var count1 = liveLocationsCount();

- link = linkifier.linkifyScriptLocation(WebInspector.targetManager.mainTarget(), null, InspectorTest.resourceTreeModel.inspectedPageURL(), 8, 0, "dummy-class");

+ link = linkifier.linkifyScriptLocation(WebInspector.targetManager.mainTarget(), null, InspectorTest.mainTarget.inspectedURL(), 8, 0, "dummy-class");

var count2 = liveLocationsCount();

InspectorTest.addResult("listeners added on raw source code: " + (count2 - count1));