[DevTools] Track URL through the target

third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 141 matching lines @@
      * @return {boolean}
      */
     accept: function(uiSourceCode)
     {
         if (!WebInspector.NavigatorView.prototype.accept(uiSourceCode))
             return false;
         return uiSourceCode.project().type() !== WebInspector.projectTypes.ContentScripts && uiSourceCode.project().type() !== WebInspector.projectTypes.Snippets;
     },
 
     /**
+     * @param {!WebInspector.UISourceCode} uiSourceCode
+     */
+    _revealIfMainTarget: function(uiSourceCode)

[dgozman, 2016/07/27 20:24:23]

Let's inline this back.

[eostroukhov-old, 2016/07/27 21:39:46]

Done.

+    {
+        var mainTarget = WebInspector.targetManager.mainTarget();
+        var inspectedURL = mainTarget && mainTarget.inspectedURL();
+        if (inspectedURL && WebInspector.networkMapping.networkURL(uiSourceCode) === inspectedURL)
+            this.revealUISourceCode(uiSourceCode, true);
+    },
+
+    /**
      * @param {!WebInspector.Event} event
      */
     _inspectedURLChanged: function(event)
     {

[dgozman, 2016/07/27 20:24:23]

Early return if event.data is not a main target.

[eostroukhov-old, 2016/07/27 21:39:46]

Done.

-        var nodes = this._uiSourceCodeNodes.valuesArray();
-        for (var i = 0; i < nodes.length; ++i) {
-            var uiSourceCode = nodes[i].uiSourceCode();
-            var inspectedPageURL = WebInspector.targetManager.inspectedPageURL();
-            if (inspectedPageURL && WebInspector.networkMapping.networkURL(uiSourceCode) === inspectedPageURL)
-                this.revealUISourceCode(uiSourceCode, true);
-        }
+        this._uiSourceCodeNodes.valuesArray().forEach((node) => this._revealIfMainTarget(node.uiSourceCode()));

[dgozman, 2016/07/27 20:24:23]

Using forEach here could be slow compared to old-style for.

[eostroukhov-old, 2016/07/27 21:39:46]

Done.

     },
 
     /**
      * @override
      * @param {!WebInspector.UISourceCode} uiSourceCode
      */
     uiSourceCodeAdded: function(uiSourceCode)
     {
-        var inspectedPageURL = WebInspector.targetManager.inspectedPageURL();
-        if (inspectedPageURL && WebInspector.networkMapping.networkURL(uiSourceCode) === inspectedPageURL)
-            this.revealUISourceCode(uiSourceCode, true);
+        this._revealIfMainTarget(uiSourceCode);
     },
 
     __proto__: WebInspector.NavigatorView.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.NavigatorView}
  */
 WebInspector.ContentScriptsNavigatorView = function()
@@ skipping 95 matching lines @@
     /**
      * @override
      */
     sourceDeleted: function(uiSourceCode)
     {
         this._handleRemoveSnippet(uiSourceCode);
     },
 
     __proto__: WebInspector.NavigatorView.prototype
 }