[Sync] Merge sync_unit_tests into components_unit_tests.

[Sync] Merge sync_unit_tests into components_unit_tests.

BUG=626114
Committed: https://crrev.com/9f7c262325b965be2a51475650d542c9791eee9d
Cr-Commit-Position: refs/heads/master@{#409060}

[maxbogue, 2016-07-26 21:07:20]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 21:08:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 21:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 21:29:21]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maxbogue, 2016-07-29 17:20:31]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 17:20:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 17:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 17:44:56]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[maxbogue, 2016-07-29 22:45:32]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 22:46:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-07-29 22:55:54]

maxbogue@chromium.org changed reviewers:
+ dpranke@chromium.org, jam@chromium.org, slan@chromium.org

[maxbogue, 2016-07-29 22:55:54]

maxbogue@chromium.org changed required reviewers:
+ dpranke@chromium.org, jam@chromium.org, slan@chromium.org

[maxbogue, 2016-07-29 22:55:55]

Hey, could you three please review this change?

+dpranke for build/, testing/, and tools/
+slan for chromecast/ (why was sync tested inside chromecast?)
+jam for everything else.

[Dirk Pranke, 2016-07-29 23:50:27]

What are we gaining by merging this into components_unit_tests ? 

It doesn't look like sync depends on anything else in components or content, so
this'll just make it much longer to build and run the tests, right? I'd defer to
jam@ as to whether we need to merge this, but it seems like a better thing to
keep it separate to me.

[commit-bot: I haz the power, 2016-07-30 00:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 00:10:30]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-07-30 01:09:12]

On 2016/07/29 23:50:27, Dirk Pranke wrote:
> What are we gaining by merging this into components_unit_tests ? 
> 
> It doesn't look like sync depends on anything else in components or content,
so
> this'll just make it much longer to build and run the tests, right? I'd defer
to
> jam@ as to whether we need to merge this, but it seems like a better thing to
> keep it separate to me.

Both jam@ and blundell@ seemed to want me to do this as part of the move. I
believe it has as much to do with being a good citizen of //components as
anything, but I plan to merge the sync_driver component into the sync component,
and this is a prerequisite for that (since it does depend on other components).

[jam, 2016-07-30 02:09:20]

lgtm

BTW these unit tests take 3 seconds to run. If there was a component which took
an exceptionally long time to run its tests, we could consider whether to split
them up. But even then, with swarming this doesn't really matter since we would
just shard them more.


On 2016/07/30 01:09:12, maxbogue wrote:
> On 2016/07/29 23:50:27, Dirk Pranke wrote:
> > What are we gaining by merging this into components_unit_tests ? 
> > 
> > It doesn't look like sync depends on anything else in components or content,
> so
> > this'll just make it much longer to build and run the tests, right? I'd
defer
> to
> > jam@ as to whether we need to merge this, but it seems like a better thing
to
> > keep it separate to me.
> 
> Both jam@ and blundell@ seemed to want me to do this as part of the move. I
> believe it has as much to do with being a good citizen of //components as
> anything, but I plan to merge the sync_driver component into the sync
component,
> and this is a prerequisite for that (since it does depend on other
components).

[Dirk Pranke, 2016-07-31 02:37:42]

ok, lgtm.

[slan, 2016-08-01 15:39:00]

On 2016/07/31 02:37:42, Dirk Pranke wrote:
> ok, lgtm.

maxbogue@, Chromecast has been testing //sync (now //components/sync) since
before my time, and I'm not familiar with this code.  Could you describe what
the code is used for? I can't find references in Chromium or our internal code,
so it's possible that we no longer rely on code in this directory. This change
looks fine, but I certainly don't want to remove important test coverage.

[maxbogue, 2016-08-01 17:23:05]

On 2016/08/01 15:39:00, slan wrote:
> 
> maxbogue@, Chromecast has been testing //sync (now //components/sync) since
> before my time, and I'm not familiar with this code.  Could you describe what
> the code is used for? I can't find references in Chromium or our internal
code,
> so it's possible that we no longer rely on code in this directory. This change
> looks fine, but I certainly don't want to remove important test coverage.

It's the code used for Chrome Sync, which is what syncs users' data (bookmarks,
autofill, preferences, open tabs, etc) between Chrome clients. Chromecast has no
other references to any of our code except for these couple tests, so I don't
think they're needed...

[slan, 2016-08-01 17:54:27]

On 2016/08/01 17:23:05, maxbogue wrote:
> On 2016/08/01 15:39:00, slan wrote:
> > 
> > maxbogue@, Chromecast has been testing //sync (now //components/sync) since
> > before my time, and I'm not familiar with this code.  Could you describe
what
> > the code is used for? I can't find references in Chromium or our internal
> code,
> > so it's possible that we no longer rely on code in this directory. This
change
> > looks fine, but I certainly don't want to remove important test coverage.
> 
> It's the code used for Chrome Sync, which is what syncs users' data
(bookmarks,
> autofill, preferences, open tabs, etc) between Chrome clients. Chromecast has
no
> other references to any of our code except for these couple tests, so I don't
> think they're needed...

I concur, not quite sure why those are being tested.

lgtm

[maxbogue, 2016-08-01 18:08:01]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-08-01 18:08:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-08-01 18:12:02]

The CQ bit was unchecked by maxbogue@chromium.org

[maxbogue, 2016-08-01 18:13:31]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[maxbogue, 2016-08-01 18:13:50]

The CQ bit was unchecked by maxbogue@chromium.org

[maxbogue, 2016-08-01 18:13:59]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-08-01 18:14:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, jam@chromium.org, slan@chromium.org
Link to the patchset: https://codereview.chromium.org/2186733002/#ps60001
(title: "Remove from chromium.memory.full.json")

[commit-bot: I haz the power, 2016-08-01 18:14:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 19:05:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 19:05:21]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[maxbogue, 2016-08-01 20:17:41]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-08-01 20:18:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 21:25:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-01 21:29:21]

Description was changed from

==========
[Sync] Merge sync_unit_tests into components_unit_tests.

BUG=626114
==========

to

==========
[Sync] Merge sync_unit_tests into components_unit_tests.

BUG=626114

Committed: https://crrev.com/9f7c262325b965be2a51475650d542c9791eee9d
Cr-Commit-Position: refs/heads/master@{#409060}
==========

[commit-bot: I haz the power, 2016-08-01 21:29:23]

Patchset 4 (id:??) landed as
https://crrev.com/9f7c262325b965be2a51475650d542c9791eee9d
Cr-Commit-Position: refs/heads/master@{#409060}

[Mathieu, 2016-08-01 22:20:43]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2205613002/ by mathp@chromium.org.

The reason for reverting is: Seems to be causing compile failure on Linux
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
.