Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2186713002: Remove onscroll/onresize EventHandler supper from ViewportAPI (Closed)

Created:
4 years, 4 months ago by ymalik
Modified:
4 years, 4 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove onscroll/onresize EventHandler supper from ViewportAPI This was added in https://codereview.chromium.org/2108953002 but on* handlers exist for legacy reasons, so removing. BUG=624068 Committed: https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e Cr-Commit-Position: refs/heads/master@{#407955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/scroll-resize-events-fired.html View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMVisualViewport.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.idl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
ymalik
4 years, 4 months ago (2016-07-26 19:53:17 UTC) #4
bokan
lgtm lgtm
4 years, 4 months ago (2016-07-26 23:04:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186713002/1
4 years, 4 months ago (2016-07-26 23:04:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 23:08:20 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 23:09:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16924630c6f3f1b2470aef5401f90e42b190356e
Cr-Commit-Position: refs/heads/master@{#407955}

Powered by Google App Engine
This is Rietveld 408576698