Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2186683003: GN: update error message for invalid input_conversion. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: update error message for invalid input_conversion. The current message is off-putting to read every time I get input_conversion wrong. BUG= Committed: https://crrev.com/1c41ccaca266ec1272e5430a9fdc7145af043d20 Cr-Commit-Position: refs/heads/master@{#409008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/input_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein_C
4 years, 4 months ago (2016-07-27 11:36:43 UTC) #2
brettw
lgtm
4 years, 4 months ago (2016-08-01 18:02:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186683003/1
4 years, 4 months ago (2016-08-01 18:03:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 18:46:48 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 18:48:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c41ccaca266ec1272e5430a9fdc7145af043d20
Cr-Commit-Position: refs/heads/master@{#409008}

Powered by Google App Engine
This is Rietveld 408576698