SkPaint intercept API for SkTextBlob and horizontal text

SkPaint intercept API for SkTextBlob and horizontal text

Add getPosTextHIntercepts(), getTextBlobIntercepts().

Consolidate the implementation in GetTextIntercepts<> template.

BUG=chormium:581456
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186663004

Committed: https://skia.googlesource.com/skia/+/eae6a9127707b9391546012d11bcc7d9920dfa6d

[f(malita), 2016-07-27 23:46:29]

Description was changed from

==========
SkPaint intercept API for SkTextBlob and horizontal text

Add getPosTextHIntercepts(), getTextBlobIntercepts().

BUG=chormium:581456
R=caryclark@google.com,reed@google.com
==========

to

==========
SkPaint intercept API for SkTextBlob and horizontal text

Add getPosTextHIntercepts(), getTextBlobIntercepts().

BUG=chormium:581456
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186663004
==========

[f(malita), 2016-07-27 23:52:18]

Description was changed from

==========
SkPaint intercept API for SkTextBlob and horizontal text

Add getPosTextHIntercepts(), getTextBlobIntercepts().

BUG=chormium:581456
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186663004
==========

to

==========
SkPaint intercept API for SkTextBlob and horizontal text

Add getPosTextHIntercepts(), getTextBlobIntercepts().

Consolidate the implementation in GetTextIntercepts<> template.

BUG=chormium:581456
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186663004
==========

[f(malita), 2016-07-27 23:55:17]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 23:55:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-07-28 00:03:25]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 00:03:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-07-28 00:28:04]

The CQ bit was unchecked by fmalita@chromium.org

[reed1, 2016-07-28 01:33:43]

Is this defined for multi-line blobs?

[caryclark, 2016-07-28 12:42:04]

lgtm

[f(malita), 2016-07-28 12:57:12]

On 2016/07/28 01:33:43, reed1 wrote:
> Is this defined for multi-line blobs?

It should work, but not particularly well: if the intent is to underline
multiple lines, you'd have to call it multiple times with different bounds
(which also means the caller has to be aware of internal line topology).  Not
sure how to improve on that, because what a "line" means is up the the client
and I don't think we can figure it out internally.

FWIW Blink is not using multi-line blobs at the moment.

[f(malita), 2016-07-28 13:07:55]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 13:08:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 13:58:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 13:58:05]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-07-28 14:23:35]

lgtm

lets file a bug to test multi-line blobs and non-monotonic positions

[f(malita), 2016-07-28 16:46:15]

On 2016/07/28 14:23:35, reed1 wrote:
> lgtm
> 
> lets file a bug to test multi-line blobs and non-monotonic positions

Done: https://bugs.chromium.org/p/skia/issues/detail?id=5590

[f(malita), 2016-07-28 16:46:19]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-07-28 16:46:20]

The patchset sent to the CQ was uploaded after l-g-t-m from caryclark@google.com
Link to the patchset: https://codereview.chromium.org/2186663004/#ps80001
(title: "GM size, comments")

[commit-bot: I haz the power, 2016-07-28 16:46:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 16:47:26]

Description was changed from

==========
SkPaint intercept API for SkTextBlob and horizontal text

Add getPosTextHIntercepts(), getTextBlobIntercepts().

Consolidate the implementation in GetTextIntercepts<> template.

BUG=chormium:581456
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186663004
==========

to

==========
SkPaint intercept API for SkTextBlob and horizontal text

Add getPosTextHIntercepts(), getTextBlobIntercepts().

Consolidate the implementation in GetTextIntercepts<> template.

BUG=chormium:581456
R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186663004

Committed:
https://skia.googlesource.com/skia/+/eae6a9127707b9391546012d11bcc7d9920dfa6d
==========

[commit-bot: I haz the power, 2016-07-28 16:47:27]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/eae6a9127707b9391546012d11bcc7d9920dfa6d

[drott, 2016-08-02 06:39:11]

Thanks very much for landing this, Florin. I'll look into integrating this to
Blink.