[DevTools] Remove V8InspectorSession::backtraceObjectGroup.

third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 116 matching lines @@
         for (var id in this._breakpointElements) {
             var element = this._breakpointElements[id];
             if (element._node === node && element._checkboxElement.checked)
                 return true;
         }
         return false;
     },
 
     /**
      * @param {!WebInspector.DebuggerPausedDetails} details
-     * @param {function(!Element)} callback
+     * @return {!Element}
      */
-    createBreakpointHitStatusMessage: function(details, callback)
+    createBreakpointHitStatusMessage: function(details)
     {
         var auxData = /** @type {!Object} */ (details.auxData);
+        var message = "Paused on a \"%s\" breakpoint.";
+        var substitutions = [];
+        substitutions.push(this._breakpointTypeLabels[auxData["type"]]);
+
         var domModel = WebInspector.DOMModel.fromTarget(details.target());
         if (!domModel)
-            return;
-        if (auxData.type === this._breakpointTypes.SubtreeModified) {
-            var targetNodeObject = details.target().runtimeModel.createRemoteObject(auxData["targetNode"]);
-            domModel.pushObjectAsNodeToFrontend(targetNodeObject, didPushNodeToFrontend.bind(this));
-        } else {
-            this._doCreateBreakpointHitStatusMessage(auxData, domModel.nodeForId(auxData.nodeId), null, callback);
-        }
+            return WebInspector.formatLocalized(message, substitutions);
 
-        /**
-         * @param {?WebInspector.DOMNode} targetNode
-         * @this {WebInspector.DOMBreakpointsSidebarPane}
-         */
-        function didPushNodeToFrontend(targetNode)
-        {
-            if (targetNode)
-                targetNodeObject.release();
-            this._doCreateBreakpointHitStatusMessage(auxData, domModel.nodeForId(auxData.nodeId), targetNode, callback);
-        }
-    },
+        var node = domModel.nodeForId(auxData["nodeId"]);
+        var linkifiedNode = WebInspector.DOMPresentationUtils.linkifyNodeReference(node);
+        substitutions.push(linkifiedNode);
 
-    /**
-     * @param {!Object} auxData
-     * @param {?WebInspector.DOMNode} node
-     * @param {?WebInspector.DOMNode} targetNode
-     * @param {function(!Element)} callback
-     */
-    _doCreateBreakpointHitStatusMessage: function(auxData, node, targetNode, callback)
-    {
-        var message;
-        var typeLabel = this._breakpointTypeLabels[auxData.type];
-        var linkifiedNode = WebInspector.DOMPresentationUtils.linkifyNodeReference(node);
-        var substitutions = [typeLabel, linkifiedNode];
-        var targetNodeLink = "";
-        if (targetNode)
-            targetNodeLink = WebInspector.DOMPresentationUtils.linkifyNodeReference(targetNode);
+        var targetNode = auxData["targetNode"] ? domModel.nodeForId(auxData["targetNode"]) : null;

[kozy, 2016/07/26 17:27:56]

targetNodeId?

[dgozman, 2016/07/26 19:12:16]

Done.

+        var targetNodeLink = targetNode ? WebInspector.DOMPresentationUtils.linkifyNodeReference(targetNode) : "";
 
         if (auxData.type === this._breakpointTypes.SubtreeModified) {
-            if (auxData.insertion) {
+            if (auxData["insertion"]) {
                 if (targetNode !== node) {
                     message = "Paused on a \"%s\" breakpoint set on %s, because a new child was added to its descendant %s.";
                     substitutions.push(targetNodeLink);
                 } else
                     message = "Paused on a \"%s\" breakpoint set on %s, because a new child was added to that node.";
             } else {
                 message = "Paused on a \"%s\" breakpoint set on %s, because its descendant %s was removed.";
                 substitutions.push(targetNodeLink);
             }
-        } else
+        } else {
             message = "Paused on a \"%s\" breakpoint set on %s.";
+        }
 
-        var element = WebInspector.formatLocalized(message, substitutions);
-
-        callback(element);
+        return WebInspector.formatLocalized(message, substitutions);
     },
 
     _nodeRemoved: function(event)
     {
         var node = event.data.node;
         this._removeBreakpointsForNode(event.data.node);
         var children = node.children();
         if (!children)
             return;
         for (var i = 0; i < children.length; ++i)
@@ skipping 260 matching lines @@
             this._wrappedPane.show(this.element);
     },
 
     __proto__: WebInspector.View.prototype
 }
 
 /**
  * @type {!WebInspector.DOMBreakpointsSidebarPane}
  */
 WebInspector.domBreakpointsSidebarPane;