Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: src/handles.cc

Issue 218663005: Reland and fix "Fix LoadFieldByIndex to take mutable heap-numbers into account."" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix number of arguments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 664 matching lines...) Expand 10 before | Expand all | Expand 10 after
675 if (!(details.IsDontEnum() || key->IsSymbol())) { 675 if (!(details.IsDontEnum() || key->IsSymbol())) {
676 storage->set(index, key); 676 storage->set(index, key);
677 if (!indices.is_null()) { 677 if (!indices.is_null()) {
678 if (details.type() != FIELD) { 678 if (details.type() != FIELD) {
679 indices = Handle<FixedArray>(); 679 indices = Handle<FixedArray>();
680 } else { 680 } else {
681 int field_index = descs->GetFieldIndex(i); 681 int field_index = descs->GetFieldIndex(i);
682 if (field_index >= map->inobject_properties()) { 682 if (field_index >= map->inobject_properties()) {
683 field_index = -(field_index - map->inobject_properties() + 1); 683 field_index = -(field_index - map->inobject_properties() + 1);
684 } 684 }
685 field_index = field_index << 1;
686 if (details.representation().IsDouble()) {
687 field_index |= 1;
688 }
685 indices->set(index, Smi::FromInt(field_index)); 689 indices->set(index, Smi::FromInt(field_index));
686 } 690 }
687 } 691 }
688 index++; 692 index++;
689 } 693 }
690 } 694 }
691 ASSERT(index == storage->length()); 695 ASSERT(index == storage->length());
692 696
693 Handle<FixedArray> bridge_storage = 697 Handle<FixedArray> bridge_storage =
694 isolate->factory()->NewFixedArray( 698 isolate->factory()->NewFixedArray(
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 Handle<Code> code) { 763 Handle<Code> code) {
760 heap->EnsureWeakObjectToCodeTable(); 764 heap->EnsureWeakObjectToCodeTable();
761 Handle<DependentCode> dep(heap->LookupWeakObjectToCodeDependency(*object)); 765 Handle<DependentCode> dep(heap->LookupWeakObjectToCodeDependency(*object));
762 dep = DependentCode::Insert(dep, DependentCode::kWeaklyEmbeddedGroup, code); 766 dep = DependentCode::Insert(dep, DependentCode::kWeaklyEmbeddedGroup, code);
763 CALL_HEAP_FUNCTION_VOID(heap->isolate(), 767 CALL_HEAP_FUNCTION_VOID(heap->isolate(),
764 heap->AddWeakObjectToCodeDependency(*object, *dep)); 768 heap->AddWeakObjectToCodeDependency(*object, *dep));
765 } 769 }
766 770
767 771
768 } } // namespace v8::internal 772 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698