Issue 218663005: Reland and fix "Fix LoadFieldByIndex to take mutable heap-numbers into account.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218663005: Reland and fix "Fix LoadFieldByIndex to take mutable heap-numbers into account."" (Closed)

Created:
6 years, 8 months ago by Toon Verwaest

Modified:
6 years, 8 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reland and fix "Fix LoadFieldByIndex to take mutable heap-numbers into account."" BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20358

Patch Set 1 #

Patch Set 2 : Fix number of arguments #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+259 lines, -14 lines)			Patch
M	src/arm/lithium-arm.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	2 chunks	+49 lines, -0 lines	0 comments	Download
M	src/arm64/lithium-arm64.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/arm64/lithium-codegen-arm64.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1	2 chunks	+48 lines, -0 lines	0 comments	Download
M	src/handles.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	2 chunks	+46 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/objects.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	2 chunks	+45 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	test/mjsunit/fuzz-natives-part1.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-load-field-by-index.js	View		1 chunk	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

6 years, 8 months ago (2014-03-31 14:21:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20358 (presubmit successful).

Expand Messages | Collapse Messages