Source/core/rendering/style/RenderStyle.cpp - Issue 218663004: Changing between multicol and regular block shouldn't recreate all renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 218663004: Changing between multicol and regular block shouldn't recreate all renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/style/RenderStyle.cpp

diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp

index a4cb88432c2c76f68e13a4f1be202f7770eaf843..b7148fc6e63ea42c92ac321aee21d213127bec4b 100644

--- a/Source/core/rendering/style/RenderStyle.cpp

+++ b/Source/core/rendering/style/RenderStyle.cpp

@@ -180,7 +180,6 @@ StyleRecalcChange RenderStyle::stylePropagationDiff(const RenderStyle* oldStyle,

if (oldStyle->display() != newStyle->display()

|| oldStyle->hasPseudoStyle(FIRST_LETTER) != newStyle->hasPseudoStyle(FIRST_LETTER)

|| oldStyle->columnSpan() != newStyle->columnSpan()

- || oldStyle->specifiesColumns() != newStyle->specifiesColumns()

|| !oldStyle->contentDataEquivalent(newStyle)

|| oldStyle->hasTextCombine() != newStyle->hasTextCombine())

return Reattach;

« no previous file with comments | « Source/core/rendering/RenderMultiColumnFlowThread.cpp ('k') | no next file » | no next file with comments »