Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2000)

Unified Diff: chrome/browser/omaha_query_params/omaha_query_params.cc

Issue 218663003: Make ARM64 detection consistent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename also string param Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/build_config.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/omaha_query_params/omaha_query_params.cc
diff --git a/chrome/browser/omaha_query_params/omaha_query_params.cc b/chrome/browser/omaha_query_params/omaha_query_params.cc
index 78a5317b175d6152a7b13a4b13e966b8af6fc7dd..3f5ecc7f44076c7f5aa8fa7bfa2cea74c0509207 100644
--- a/chrome/browser/omaha_query_params/omaha_query_params.cc
+++ b/chrome/browser/omaha_query_params/omaha_query_params.cc
@@ -40,8 +40,8 @@ const char kArch[] =
"x86";
#elif defined(__arm__)
"arm";
-#elif defined(__arm64__)
- "arm64";
+#elif defined(__aarch64__)
+ "aarch64";
stuartmorgan 2014/03/31 13:26:01 Is there any reason *not* to call this arm64? Seem
Nico 2014/03/31 16:13:43 (I agree with this. The gyp target_arch value is a
Primiano Tucci (use gerrit) 2014/03/31 16:25:29 Right, me and Stuart had a discussion offline and
#elif defined(__mips__)
"mipsel";
#else
« no previous file with comments | « build/build_config.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698