Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2186573002: [x64] Apply leaq optimizations similar to leal. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Apply leaq optimizations similar to leal. So far we didn't really recognize leaq, but only leal instructions in the x64 InstructionSelector. Now that we actually generate more of them, we should also pay more attention to those. R=epertoso@chromium.org Committed: https://crrev.com/968d3bce5832b66d1a33eb252b0a43d50bbe337b Cr-Commit-Position: refs/heads/master@{#38055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M src/compiler/x64/instruction-selector-x64.cc View 3 chunks +38 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-07-26 13:53:41 UTC) #1
epertoso
lgtm
4 years, 4 months ago (2016-07-26 14:17:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186573002/1
4 years, 4 months ago (2016-07-26 14:17:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 14:18:36 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 14:19:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/968d3bce5832b66d1a33eb252b0a43d50bbe337b
Cr-Commit-Position: refs/heads/master@{#38055}

Powered by Google App Engine
This is Rietveld 408576698