Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2186553006: GN: use ccache if available and the requested compiler. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio, borenet, mtklein
CC:
borenet, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: use ccache if available and the requested compiler. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186553006 Committed: https://skia.googlesource.com/skia/+/9081ceb1236dfd1f3c7e9d5ef1d6f7c409d06aa1

Patch Set 1 #

Patch Set 2 : use returned path #

Patch Set 3 : Clang/GCC too #

Patch Set 4 : rebase #

Patch Set 5 : quotes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -38 lines) Patch
M infra/bots/recipe_modules/skia/fake_specs.py View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M infra/bots/recipe_modules/skia/gn_flavor.py View 1 2 4 1 chunk +12 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_compile.py View 1 2 2 chunks +3 lines, -1 line 0 comments Download
A + infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-Clang-x86_64-Debug-GN.json View 1 2 4 5 chunks +41 lines, -35 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86_64-Debug-GN.json View 1 2 4 1 chunk +34 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (15 generated)
mtklein_C
CCache is always a good idea, and this'll let us add Clang bots, I hope.
4 years, 4 months ago (2016-07-28 18:46:30 UTC) #5
jcgregorio
LGTM for the GN stuff, but deferring to borenet for the recipe.
4 years, 4 months ago (2016-07-28 19:10:52 UTC) #9
borenet
LGTM
4 years, 4 months ago (2016-07-29 11:27:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186553006/100001
4 years, 4 months ago (2016-07-29 11:43:52 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 12:07:47 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://skia.googlesource.com/skia/+/9081ceb1236dfd1f3c7e9d5ef1d6f7c409d06aa1

Powered by Google App Engine
This is Rietveld 408576698