Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2186533002: Remove dead code for generated code coverage. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove dead code for generated code coverage. This feature has not been used in the past few years and most likely does not even work anymore. R=ishell@chromium.org Committed: https://crrev.com/1d2793f877b89972aab5b41ac2656a6f33b84ea5 Cr-Commit-Position: refs/heads/master@{#38046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -454 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm/simulator-arm.cc View 5 chunks +0 lines, -55 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 3 chunks +0 lines, -34 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/simulator-mips.cc View 4 chunks +0 lines, -50 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 4 chunks +0 lines, -54 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +1 line, -10 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 4 chunks +0 lines, -51 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +1 line, -9 lines 0 comments Download
M src/s390/simulator-s390.cc View 4 chunks +0 lines, -45 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/x87/assembler-x87.cc View 3 chunks +0 lines, -35 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 4 months ago (2016-07-26 09:35:18 UTC) #1
Igor Sheludko
lgtm
4 years, 4 months ago (2016-07-26 11:11:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186533002/1
4 years, 4 months ago (2016-07-26 11:17:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 11:52:24 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 11:54:48 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1d2793f877b89972aab5b41ac2656a6f33b84ea5
Cr-Commit-Position: refs/heads/master@{#38046}

Powered by Google App Engine
This is Rietveld 408576698