runtime/vm/code_generator.cc - Issue 2186423002: Only reload libraries when they may have been modified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator.cc

Issue 2186423002: Only reload libraries when they may have been modified. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Code review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/code_generator.cc

diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc

index ea33dae792c80ff9b61b2a3eb07bd6b6181a1bbc..b0b3a9c14df259a671d84fe1de55d7edb8ea5701 100644

--- a/runtime/vm/code_generator.cc

+++ b/runtime/vm/code_generator.cc

@@ -1360,7 +1360,7 @@ DEFINE_RUNTIME_ENTRY(StackOverflow, 0) {

// Maybe adjust the rate of future reloads.

isolate->MaybeIncreaseReloadEveryNStackOverflowChecks();

// Issue a reload.

- isolate->ReloadSources();

+ isolate->ReloadSources(true /* force_reload */);

const Error& error = Error::Handle(isolate->sticky_reload_error());

if (!error.IsNull()) {

FATAL1("*** Isolate reload failed: %s\n", error.ToErrorCString());

« no previous file with comments | « runtime/vm/bit_vector.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »