Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: runtime/bin/vmservice_impl.cc

Issue 2186423002: Only reload libraries when they may have been modified. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Code review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/loader.dart ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice_impl.cc
diff --git a/runtime/bin/vmservice_impl.cc b/runtime/bin/vmservice_impl.cc
index d85186326f9436e679bb8999f8da1882a55062c1..871a91c7ca0298d014e94eeb032ccb4728eb8b8a 100644
--- a/runtime/bin/vmservice_impl.cc
+++ b/runtime/bin/vmservice_impl.cc
@@ -317,21 +317,21 @@ Dart_Handle VmService::GetSource(const char* name) {
Dart_Handle VmService::LoadScript(const char* name) {
Dart_Handle uri = Dart_NewStringFromCString(kVMServiceIOLibraryUri);
Dart_Handle source = GetSource(name);
- return Dart_LoadScript(uri, source, 0, 0);
+ return Dart_LoadScript(uri, Dart_Null(), source, 0, 0);
}
Dart_Handle VmService::LoadLibrary(const char* name) {
Dart_Handle uri = Dart_NewStringFromCString(kVMServiceIOLibraryUri);
Dart_Handle source = GetSource(name);
- return Dart_LoadLibrary(uri, source, 0, 0);
+ return Dart_LoadLibrary(uri, Dart_Null(), source, 0, 0);
}
Dart_Handle VmService::LoadSource(Dart_Handle library, const char* name) {
Dart_Handle uri = Dart_NewStringFromCString(name);
Dart_Handle source = GetSource(name);
- return Dart_LoadSource(library, uri, source, 0, 0);
+ return Dart_LoadSource(library, uri, Dart_Null(), source, 0, 0);
}
@@ -368,7 +368,7 @@ Dart_Handle VmService::LibraryTagHandler(Dart_LibraryTag tag,
if (Dart_IsError(source)) {
return source;
}
- return Dart_LoadSource(library, url, source, 0, 0);
+ return Dart_LoadSource(library, url, Dart_Null(), source, 0, 0);
}
« no previous file with comments | « runtime/bin/vmservice/loader.dart ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698