Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: runtime/bin/dartutils.cc

Issue 2186423002: Only reload libraries when they may have been modified. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Code review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/builtin.cc ('k') | runtime/bin/gen_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dartutils.cc
diff --git a/runtime/bin/dartutils.cc b/runtime/bin/dartutils.cc
index 1b1f42faced0ede551963534668366cb57459a85..e7237641bb8d0b94897ea46d154758fed0e3f50b 100644
--- a/runtime/bin/dartutils.cc
+++ b/runtime/bin/dartutils.cc
@@ -434,7 +434,7 @@ Dart_Handle DartUtils::LibraryTagHandler(Dart_LibraryTag tag,
Dart_Handle part_uri_obj = DartUtils::NewString(part_uri);
free(part_uri);
return Dart_LoadSource(library,
- part_uri_obj,
+ part_uri_obj, Dart_Null(),
Builtin::PartSource(id, url_string), 0, 0);
}
// All cases should have been handled above.
@@ -570,7 +570,8 @@ void FUNCTION_NAME(Builtin_LoadSource)(Dart_NativeArguments args) {
result = DartUtils::NewError("%s is not a valid UTF-8 script",
resolved_script_uri);
} else {
- result = Dart_LoadScript(resolved_script_uri, source, 0, 0);
+ result = Dart_LoadScript(resolved_script_uri, Dart_Null(),
+ source, 0, 0);
}
}
} else {
@@ -582,14 +583,16 @@ void FUNCTION_NAME(Builtin_LoadSource)(Dart_NativeArguments args) {
resolved_script_uri);
} else {
if (tag == Dart_kImportTag) {
- result = Dart_LoadLibrary(resolved_script_uri, source, 0, 0);
+ result = Dart_LoadLibrary(resolved_script_uri, Dart_Null(),
+ source, 0, 0);
} else {
ASSERT(tag == Dart_kSourceTag);
Dart_Handle library = Dart_LookupLibrary(library_uri);
if (Dart_IsError(library)) {
Dart_PropagateError(library);
}
- result = Dart_LoadSource(library, resolved_script_uri, source, 0, 0);
+ result = Dart_LoadSource(library, resolved_script_uri, Dart_Null(),
+ source, 0, 0);
}
}
}
« no previous file with comments | « runtime/bin/builtin.cc ('k') | runtime/bin/gen_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698