Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: ash/test/ash_md_test_base.cc

Issue 2186363002: Set Ash material design mode in tests properly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/test/ash_md_test_base.cc
diff --git a/ash/test/ash_md_test_base.cc b/ash/test/ash_md_test_base.cc
index a0edbd35450a5d31044c0d372b1503c802ffa0b1..fb8f24686f389efff487b528e2dd48be065c18e3 100644
--- a/ash/test/ash_md_test_base.cc
+++ b/ash/test/ash_md_test_base.cc
@@ -15,28 +15,31 @@ AshMDTestBase::AshMDTestBase() {}
AshMDTestBase::~AshMDTestBase() {}
void AshMDTestBase::SetUp() {
- AshTestBase::SetUp();
-
- material_design_state_.reset(new test::MaterialDesignControllerTestAPI(
- MaterialDesignController::Mode::NON_MATERIAL));
- const int non_md_shelf_size = GetShelfConstant(SHELF_SIZE);
- const int non_md_auto_hide_shelf_size =
- GetShelfConstant(SHELF_INSETS_FOR_AUTO_HIDE);
-
- material_design_state_.reset(
- new test::MaterialDesignControllerTestAPI(GetParam()));
- const int md_state_shelf_size = GetShelfConstant(SHELF_SIZE);
- const int md_state_auto_hide_shelf_size =
- GetShelfConstant(SHELF_INSETS_FOR_AUTO_HIDE);
-
- md_maximized_window_height_offset_ = non_md_shelf_size - md_state_shelf_size;
+ int non_md_shelf_size = 0;
+ int non_md_auto_hide_shelf_size = 0;
+ int md_shelf_size = 0;
+ int md_auto_hide_shelf_size = 0;
+
+ {
+ test::MaterialDesignControllerTestAPI md_state(
+ MaterialDesignController::Mode::NON_MATERIAL);
+ non_md_shelf_size = GetShelfConstant(SHELF_SIZE);
+ non_md_auto_hide_shelf_size = GetShelfConstant(SHELF_INSETS_FOR_AUTO_HIDE);
+ }
+
+ {
+ test::MaterialDesignControllerTestAPI md_state(GetParam());
+ md_shelf_size = GetShelfConstant(SHELF_SIZE);
+ md_auto_hide_shelf_size = GetShelfConstant(SHELF_INSETS_FOR_AUTO_HIDE);
+ }
+
+ md_maximized_window_height_offset_ = non_md_shelf_size - md_shelf_size;
md_auto_hidden_shelf_height_offset_ =
- non_md_auto_hide_shelf_size - md_state_auto_hide_shelf_size;
-}
+ non_md_auto_hide_shelf_size - md_auto_hide_shelf_size;
+
+ set_material_mode(GetParam());
-void AshMDTestBase::TearDown() {
- material_design_state_.reset();
- AshTestBase::TearDown();
+ AshTestBase::SetUp();
}
int AshMDTestBase::GetMdMaximizedWindowHeightOffset() {
« no previous file with comments | « ash/test/ash_md_test_base.h ('k') | ash/test/ash_test_base.h » ('j') | ash/test/ash_test_base.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698