Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: components/nacl/browser/nacl_process_host.cc

Issue 218633011: Stop doing unnecessary initialization in non-SFI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | components/nacl/loader/nacl_listener.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/browser/nacl_process_host.h" 5 #include "components/nacl/browser/nacl_process_host.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 774 matching lines...) Expand 10 before | Expand all | Expand 10 after
785 785
786 NaClStartParams params; 786 NaClStartParams params;
787 params.validation_cache_enabled = nacl_browser->ValidationCacheIsEnabled(); 787 params.validation_cache_enabled = nacl_browser->ValidationCacheIsEnabled();
788 params.validation_cache_key = nacl_browser->GetValidationCacheKey(); 788 params.validation_cache_key = nacl_browser->GetValidationCacheKey();
789 params.version = NaClBrowser::GetDelegate()->GetVersionString(); 789 params.version = NaClBrowser::GetDelegate()->GetVersionString();
790 params.enable_exception_handling = enable_exception_handling_; 790 params.enable_exception_handling = enable_exception_handling_;
791 params.enable_debug_stub = enable_debug_stub_ && 791 params.enable_debug_stub = enable_debug_stub_ &&
792 NaClBrowser::GetDelegate()->URLMatchesDebugPatterns(manifest_url_); 792 NaClBrowser::GetDelegate()->URLMatchesDebugPatterns(manifest_url_);
793 // Enable PPAPI proxy channel creation only for renderer processes. 793 // Enable PPAPI proxy channel creation only for renderer processes.
794 params.enable_ipc_proxy = enable_ppapi_proxy(); 794 params.enable_ipc_proxy = enable_ppapi_proxy();
795 params.uses_irt = uses_irt_; 795 params.uses_irt = uses_irt_ && !uses_nonsfi_mode_;
796 params.enable_dyncode_syscalls = enable_dyncode_syscalls_; 796 params.enable_dyncode_syscalls = enable_dyncode_syscalls_;
797 797
798 const ChildProcessData& data = process_->GetData(); 798 const ChildProcessData& data = process_->GetData();
799 if (!ShareHandleToSelLdr(data.handle, 799 if (!ShareHandleToSelLdr(data.handle,
800 internal_->socket_for_sel_ldr, true, 800 internal_->socket_for_sel_ldr, true,
801 &params.handles)) { 801 &params.handles)) {
802 return false; 802 return false;
803 } 803 }
804 804
805 if (params.uses_irt) { 805 if (params.uses_irt) {
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
1084 process_handle.Take(), info, 1084 process_handle.Take(), info,
1085 base::MessageLoopProxy::current(), 1085 base::MessageLoopProxy::current(),
1086 base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker, 1086 base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker,
1087 weak_factory_.GetWeakPtr())); 1087 weak_factory_.GetWeakPtr()));
1088 return true; 1088 return true;
1089 } 1089 }
1090 } 1090 }
1091 #endif 1091 #endif
1092 1092
1093 } // namespace nacl 1093 } // namespace nacl
OLDNEW
« no previous file with comments | « no previous file | components/nacl/loader/nacl_listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698