Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: content/browser/android/in_process/synchronous_compositor_output_surface.cc

Issue 218633010: cc: Handle retroactive BeginFrames in the Scheduler. (Closed) Base URL: http://git.chromium.org/chromium/src.git@compositorVsyncDisable
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/in_process/synchronous_compositor_output_surface.cc
diff --git a/content/browser/android/in_process/synchronous_compositor_output_surface.cc b/content/browser/android/in_process/synchronous_compositor_output_surface.cc
index 88983d56b513a75522e51db80a6f4c9bc170f29a..4a04bb11294b372bc61b77b8d02159c3f7ecc987 100644
--- a/content/browser/android/in_process/synchronous_compositor_output_surface.cc
+++ b/content/browser/android/in_process/synchronous_compositor_output_surface.cc
@@ -122,11 +122,9 @@ void SynchronousCompositorOutputSurface::Reshape(
// Intentional no-op: surface size is controlled by the embedder.
}
-void SynchronousCompositorOutputSurface::SetNeedsBeginImplFrame(
- bool enable) {
+void SynchronousCompositorOutputSurface::SetNeedsBeginFrame(bool enable) {
DCHECK(CalledOnValidThread());
needs_begin_impl_frame_ = enable;
- client_ready_for_begin_impl_frame_ = true;
SynchronousCompositorOutputSurfaceDelegate* delegate = GetDelegate();
if (delegate && !invoking_composite_)
delegate->SetContinuousInvalidate(needs_begin_impl_frame_);
@@ -223,7 +221,7 @@ void SynchronousCompositorOutputSurface::InvokeComposite(
SetExternalDrawConstraints(
adjusted_transform, viewport, clip, valid_for_tile_management);
SetNeedsRedrawRect(gfx::Rect(viewport.size()));
- BeginImplFrame(cc::BeginFrameArgs::CreateForSynchronousCompositor());
+ BeginFrame(cc::BeginFrameArgs::CreateForSynchronousCompositor());
// After software draws (which might move the viewport arbitrarily), restore
// the previous hardware viewport to allow CC's tile manager to prioritize
@@ -245,9 +243,8 @@ void SynchronousCompositorOutputSurface::InvokeComposite(
delegate->SetContinuousInvalidate(needs_begin_impl_frame_);
}
-void
-SynchronousCompositorOutputSurface::PostCheckForRetroactiveBeginImplFrame() {
- // Synchronous compositor cannot perform retroactive BeginImplFrames, so
+void SynchronousCompositorOutputSurface::PostCheckForRetroactiveBeginFrame() {
+ // Synchronous compositor cannot perform retroactive BeginFrames, so
// intentionally no-op here.
}

Powered by Google App Engine
This is Rietveld 408576698