Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: runtime/vm/object_reload.cc

Issue 2186303002: Added JSON reporting to reload. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate_reload.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_reload.cc
diff --git a/runtime/vm/object_reload.cc b/runtime/vm/object_reload.cc
index 577cb910266eaaf5ed0281fe807eaa24b580ce22..c646dd63bb50452d30ebcb1d3aba7b76fcf57627 100644
--- a/runtime/vm/object_reload.cc
+++ b/runtime/vm/object_reload.cc
@@ -412,6 +412,16 @@ class TypeParametersChanged : public ClassReasonForCancelling {
return String::NewFormatted(
"Limitation: type parameters have changed for %s", from_.ToCString());
}
+
+ void AppendTo(JSONArray* array) {
+ JSONObject jsobj(array);
+ jsobj.AddProperty("type", "ReasonForCancellingReload");
+ jsobj.AddProperty("kind", "TypeParametersChanged");
+ jsobj.AddProperty("class", to_);
+ jsobj.AddProperty("message",
+ "Limitation: changing type parameters "
+ "does not work with hot reload.");
+ }
};
« no previous file with comments | « runtime/vm/isolate_reload.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698