Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2186293002: [gdb] Define print functions used by gdb macros in the top level namespace to make them always be a… (Closed)

Created:
4 years, 4 months ago by Igor Sheludko
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gdb] Define print functions used by gdb macros in the top level namespace to make them always be available. This should fix the following errors that sometimes appear when using V8 gdb macros: Cannot evaluate function -- may be inlined or No symbol "xxx" in namespace "v8::internal". Committed: https://crrev.com/e063b7118c8399ed4332e26287d4a7b6aa69b068 Cr-Commit-Position: refs/heads/master@{#38145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
M src/objects-printer.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M tools/gdbinit View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Igor Sheludko
4 years, 4 months ago (2016-07-28 15:53:10 UTC) #3
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-07-28 16:55:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186293002/1
4 years, 4 months ago (2016-07-28 17:07:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 17:09:19 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 17:09:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e063b7118c8399ed4332e26287d4a7b6aa69b068
Cr-Commit-Position: refs/heads/master@{#38145}

Powered by Google App Engine
This is Rietveld 408576698