chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc - Issue 2186233003: Introduce activation scope logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc

Issue 2186233003: Introduce activation scope logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: one feature Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/subresource_filter/subresource_filter_browsertest.cc » ('j') | components/subresource_filter/core/common/activation_scope.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc

diff --git a/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc b/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc

index c740f9aff78dfa338653365b968d1506dbee02b9..0df80356f12e619fc0ac6dac32733ef7fdecb9b5 100644

--- a/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc

+++ b/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc

@@ -163,7 +163,8 @@ TEST_F(SubresourceFilterComponentInstallerTest,

base::FieldTrialList field_trial_list(nullptr);

subresource_filter::testing::ScopedSubresourceFilterFeatureToggle

scoped_feature_toggle(base::FeatureList::OVERRIDE_DISABLE_FEATURE,

- subresource_filter::kActivationStateEnabled);

+ subresource_filter::kActivationStateEnabled,

+ subresource_filter::kActivationScopeDisabled);

std::unique_ptr<SubresourceFilterMockComponentUpdateService>

component_updater(new SubresourceFilterMockComponentUpdateService());

EXPECT_CALL(*component_updater, RegisterComponent(testing::_)).Times(0);

@@ -176,7 +177,8 @@ TEST_F(SubresourceFilterComponentInstallerTest,

base::FieldTrialList field_trial_list(nullptr);

subresource_filter::testing::ScopedSubresourceFilterFeatureToggle

scoped_feature_toggle(base::FeatureList::OVERRIDE_ENABLE_FEATURE,

- subresource_filter::kActivationStateDisabled);

+ subresource_filter::kActivationStateDisabled,

+ subresource_filter::kActivationScopeDisabled);

std::unique_ptr<SubresourceFilterMockComponentUpdateService>

component_updater(new SubresourceFilterMockComponentUpdateService());

EXPECT_CALL(*component_updater, RegisterComponent(testing::_)).Times(1);