components/subresource_filter/core/browser/subresource_filter_features_test_support.cc - Issue 2186233003: Introduce activation scope logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

Issue 2186233003: Introduce activation scope logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adressed-comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/core/browser/subresource_filter_features_test_support.h ('k') | components/subresource_filter/core/browser/subresource_filter_features_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

diff --git a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

index 6b9cee67bab8835823be2e3637d6e3ac382113c6..87dd1a0b8c39ce3f53c5a59680b1ac03c8e1473b 100644

--- a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

+++ b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

@@ -22,12 +22,14 @@ const char kTestExperimentGroupName[] = "GroupNameShouldNotMatter";

ScopedSubresourceFilterFeatureToggle::ScopedSubresourceFilterFeatureToggle(

base::FeatureList::OverrideState feature_state,

- const std::string& maximum_activation_state) {

+ const std::string& maximum_activation_state,

+ const std::string& activation_scope) {

base::FeatureList::ClearInstanceForTesting();

variations::testing::ClearAllVariationParams();

std::map<std::string, std::string> variation_params;

variation_params[kActivationStateParameterName] = maximum_activation_state;

+ variation_params[kActivationScopeParameterName] = activation_scope;

EXPECT_TRUE(variations::AssociateVariationParams(

kTestFieldTrialName, kTestExperimentGroupName, variation_params));