Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2186233002: Measure EventSource usage in Document and Workers. (Closed)

Created:
4 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 4 months ago
Reviewers:
Mike West
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-events_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure EventSource usage in Document and Workers. BUG=632138 Committed: https://crrev.com/6ef97ec77b258a6285cdb77c45664ab6fce8e9d7 Cr-Commit-Position: refs/heads/master@{#408423}

Patch Set 1 #

Total comments: 4

Patch Set 2 : moved to the right place #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/EventSource.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
mlamouri (slow - plz ping)
mkwst@, PTAL. This sounds simple and might help Mozilla decides whether they should implement the ...
4 years, 4 months ago (2016-07-28 11:13:41 UTC) #2
Mike West
https://codereview.chromium.org/2186233002/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2186233002/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h#newcode1285 third_party/WebKit/Source/core/frame/UseCounter.h:1285: PerformanceResourceTimingSizes = 1478, Yours need to come after this. ...
4 years, 4 months ago (2016-07-28 12:34:11 UTC) #7
Mike West
https://codereview.chromium.org/2186233002/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2186233002/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h#newcode1285 third_party/WebKit/Source/core/frame/UseCounter.h:1285: PerformanceResourceTimingSizes = 1478, On 2016/07/28 at 12:34:11, Mike West ...
4 years, 4 months ago (2016-07-28 12:34:39 UTC) #8
mlamouri (slow - plz ping)
PTAL. https://codereview.chromium.org/2186233002/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2186233002/diff/1/third_party/WebKit/Source/core/frame/UseCounter.h#newcode1285 third_party/WebKit/Source/core/frame/UseCounter.h:1285: PerformanceResourceTimingSizes = 1478, On 2016/07/28 at 12:34:39, Mike ...
4 years, 4 months ago (2016-07-28 12:39:43 UTC) #9
Mike West
LGTM!
4 years, 4 months ago (2016-07-28 13:40:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186233002/20001
4 years, 4 months ago (2016-07-28 13:54:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/251824)
4 years, 4 months ago (2016-07-28 15:22:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186233002/20001
4 years, 4 months ago (2016-07-28 16:09:02 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 17:34:02 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 17:37:20 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ef97ec77b258a6285cdb77c45664ab6fce8e9d7
Cr-Commit-Position: refs/heads/master@{#408423}

Powered by Google App Engine
This is Rietveld 408576698