Issue 218623020: Files.app: fix a bug that low-space warning is not shown at all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218623020: Files.app: fix a bug that low-space warning is not shown at all. (Closed)

Created:
6 years, 8 months ago by kinaba

Modified:
6 years, 8 months ago

Reviewers:
yoshiki, fukino

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Files.app: fix a bug that low-space warning is not shown at all. fileBrowserPrivate.getSizeStats takes volumeId as the argument, not the root URL. BUG=350101 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261444

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/file_manager/foreground/js/drive_banners.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

kinaba

@fukino, could you verify that this change eliminates 'undefined' value? @yoshiki: as an OWNER.

6 years, 8 months ago (2014-04-03 04:14:36 UTC) #1

fukino

On 2014/04/03 04:14:36, kinaba wrote: > @fukino, could you verify that this change eliminates 'undefined' ...

6 years, 8 months ago (2014-04-03 04:29:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/218623020/1

6 years, 8 months ago (2014-04-03 14:27:18 UTC) #5

Message was sent while issue was closed.

Change committed as 261444