Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 218623016: Remove Hack used for merging dependent chromium and blink patches (Closed)

Created:
6 years, 8 months ago by Sunil Ratnu
Modified:
6 years, 8 months ago
Reviewers:
jamesr, abarth-chromium
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove Hack used for merging dependent chromium and blink patches To merge the dependent patches https://codereview.chromium.org/137893025/ and https://codereview.chromium.org/138523003/ , older definition of the function didActivateCompositor() was also needed to be kept. But since both of these patches have landed now, we can land this patch. This patch removes the older definitions from the code. BUG=None TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Sunil Ratnu
Since jamesr is out of office and I am not sure for how many days ...
6 years, 8 months ago (2014-04-01 09:42:24 UTC) #1
abarth-chromium
LGTM I'm not an owner here. Maybe this change is simple enough to TBR to ...
6 years, 8 months ago (2014-04-01 16:50:53 UTC) #2
Sunil Ratnu
On 2014/04/01 16:50:53, abarth wrote: > LGTM > > I'm not an owner here. Maybe ...
6 years, 8 months ago (2014-04-01 18:50:43 UTC) #3
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 8 months ago (2014-04-02 04:20:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/218623016/1
6 years, 8 months ago (2014-04-02 04:21:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 05:39:07 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58984
6 years, 8 months ago (2014-04-02 05:39:08 UTC) #7
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 8 months ago (2014-04-22 14:21:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/218623016/1
6 years, 8 months ago (2014-04-22 14:21:16 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 16:12:44 UTC) #10
Message was sent while issue was closed.
Change committed as 265270

Powered by Google App Engine
This is Rietveld 408576698