Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Unified Diff: sync/protocol/sync.proto

Issue 218623014: [Sync] Add context proto and directory support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update protos Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/sync.proto
diff --git a/sync/protocol/sync.proto b/sync/protocol/sync.proto
index b9f0de538db0c40628daa4f99612a3be5c014f1d..e69f51015d78579d795093cb55a4545065595210 100644
--- a/sync/protocol/sync.proto
+++ b/sync/protocol/sync.proto
@@ -408,6 +408,9 @@ message CommitMessage {
// syncing a particular data type regardless of whether a commit for that
// datatype is currently being sent up.
optional ClientConfigParams config_params = 4;
+
+ // Set of optional per-client datatype contexts.
+ repeated DataTypeContext client_contexts = 5;
};
// This message communicates additional per-type information related to
@@ -626,6 +629,9 @@ message GetUpdatesMessage {
// Whether this GU also serves as a retry GU. Any GU that happens after
// retry timer timeout is a retry GU effectively.
optional bool is_retry = 10 [default = false];
+
+ // Set of optional per-client datatype contexts.
maniscalco 2014/04/03 16:59:37 Just for my own benefit... I assume that you're us
Nicolas Zea 2014/04/03 21:01:11 No, there should only be one per type.
+ repeated DataTypeContext client_contexts = 11;
maniscalco 2014/04/03 16:59:37 I don't think we've been consistent, but going for
Nicolas Zea 2014/04/03 21:01:11 I don't think we have one. I try to use plural tho
};
message AuthenticateMessage {
@@ -669,6 +675,17 @@ message ClientStatus {
optional bool hierarchy_conflict_detected = 1;
}
+// A single datatype's sync context. Allows the datatype to pass along
+// datatype specific information with its own server backend.
+message DataTypeContext {
+ // The type this context is associated with.
+ optional int32 type = 1;
maniscalco 2014/04/03 16:59:37 Elsewhere in this file I see "data_type_id". Is t
Nicolas Zea 2014/04/03 21:01:11 Done.
+ // The context for the datatype.
+ optional bytes context = 2;
+ // The version of the context.
+ optional int64 version = 3;
+}
+
message ClientToServerMessage {
required string share = 1;
optional int32 protocol_version = 2 [default = 31];
@@ -832,6 +849,9 @@ message GetUpdatesResponse {
// the server has updated the set of encryption keys (e.g. due to a key
// rotation).
repeated bytes encryption_keys = 6;
+
+ // Set of optional datatype contexts server mutations.
+ repeated DataTypeContext context_mutations = 7;
};
// The metadata response for GetUpdatesMessage. This response is sent when

Powered by Google App Engine
This is Rietveld 408576698