[Sync] Add context proto and directory support

sync/syncable/directory_backing_store.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/syncable/directory_backing_store.h"
 
 #include "build/build_config.h"
 
 #include <limits>
 
@@ skipping 17 matching lines @@
 using std::string;
 
 namespace syncer {
 namespace syncable {
 
 // This just has to be big enough to hold an UPDATE or INSERT statement that
 // modifies all the columns in the entry table.
 static const string::size_type kUpdateStatementBufferSize = 2048;
 
 // Increment this version whenever updating DB tables.
-const int32 kCurrentDBVersion = 86;
+const int32 kCurrentDBVersion = 87;
 
 // Iterate over the fields of |entry| and bind each to |statement| for
 // updating.  Returns the number of args bound.
 void BindFields(const EntryKernel& entry,
                 sql::Statement* statement) {
   int index = 0;
   int i = 0;
   for (i = BEGIN_FIELDS; i < INT64_FIELDS_END; ++i) {
     statement->BindInt64(index++, entry.ref(static_cast<Int64Field>(i)));
   }
@@ skipping 350 matching lines @@
       version_on_disk = 85;
   }
 
   // Version 86 migration converts bookmarks to the unique positioning system.
   // It also introduces a new field to store a unique ID for each bookmark.
   if (version_on_disk == 85) {
     if (MigrateVersion85To86())
       version_on_disk = 86;
   }
 
+  // Version 87 migration adds datatype contexts to the models table.
+  if (version_on_disk == 86) {
+    if (MigrateVersion86To87())
+      version_on_disk = 87;
+  }
+
   // If one of the migrations requested it, drop columns that aren't current.
   // It's only safe to do this after migrating all the way to the current
   // version.
   if (version_on_disk == kCurrentDBVersion && needs_column_refresh_) {
     if (!RefreshColumns())
       version_on_disk = 0;
   }
 
   // A final, alternative catch-all migration to simply re-sync everything.
   if (version_on_disk != kCurrentDBVersion) {
@@ skipping 840 matching lines @@
     if (!put.Run())
       return false;
     put.Reset(true);
   }
 
   SetVersion(86);
   needs_column_refresh_ = true;
   return true;
 }
 
+bool DirectoryBackingStore::MigrateVersion86To87() {
+  // Version 87 adds the datatype context to the models table.
+  if (!db_->Execute("ALTER TABLE models ADD COLUMN context blob"))

[rlarocque, 2014/04/03 01:08:06]

Should I expect to see UPDATE and SELECT statements, too, or will those be added
in a separate CL?

[Nicolas Zea, 2014/04/03 21:01:11]

I've gone ahead and added those to this CL.

+    return false;
+
+  SetVersion(87);
+  return true;
+}
+
 bool DirectoryBackingStore::CreateTables() {
   DVLOG(1) << "First run, creating tables";
   // Create two little tables share_version and share_info
   if (!db_->Execute(
           "CREATE TABLE share_version ("
           "id VARCHAR(128) primary key, data INT)")) {
     return false;
   }
 
   {
@@ skipping 216 matching lines @@
   }
   query.append(" ) ");
   values.append(" )");
   query.append(values);
   save_statement->Assign(db_->GetUniqueStatement(
       base::StringPrintf(query.c_str(), "metas").c_str()));
 }
 
 }  // namespace syncable
 }  // namespace syncer