[worklets] Add stub classes for window.animationWorklet

[worklets] Add stub classes for window.animationWorklet

This adds the code necessary just to return a Worklet object from the
window.animationWorklet attribute.

Followup patches will actually perform the wiring between this and
creating the background WorkerThread.

(Alternatively we could also start with audioWorklet as well, up to the
 reviewers; either or :).

BUG=567358
Committed: https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27
Cr-Commit-Position: refs/heads/master@{#408508}

[ikilpatrick, 2016-07-27 23:07:13]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 23:07:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 00:18:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 00:18:14]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ikilpatrick, 2016-07-28 00:43:42]

ikilpatrick@chromium.org changed reviewers:
+ flackr@chromium.org, hongchan@chromium.org, kinuko@chromium.org,
majidvp@chromium.org, nhiroki@chromium.org, yhirano@chromium.org

[ikilpatrick, 2016-07-28 00:43:43]

As described this is just adding the sub classes for animation worklet so that
we'll actually be able to test all the importing of scripts console etc for
ThreadedWorklets once have code for those parts.

[ikilpatrick, 2016-07-28 00:44:17]

On 2016/07/28 00:43:43, ikilpatrick wrote:
> As described this is just adding the sub classes for animation worklet so that
> we'll actually be able to test all the importing of scripts console etc for
> ThreadedWorklets once have code for those parts.

s/sub/stub/

We could also start with audioWorklet as well, I'm indifferent :)

[nhiroki, 2016-07-28 06:13:53]

lgtm with nits

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
(right):

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp:21:
AnimationWorklet::AnimationWorklet(LocalFrame* frame, ExecutionContext*
executionContext)
|frame| is not necessary?

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
(right):

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h:9:
#include "modules/worklet/ThreadedWorkletGlobalScopeProxy.h"
This is included in *.cpp, too.
Maybe forward declaration can work.

[haraken, 2016-07-28 08:27:33]

LGTM

[yhirano, 2016-07-28 14:48:17]

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h
(right):

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h:33:
mutable Member<AnimationWorklet> m_animationWorklet;
Why is this mutable? Can't we remove the const qualifier from
|animationWorklet|?

[flackr, 2016-07-28 15:25:34]

flackr@chromium.org changed reviewers:
+ haraken@chromium.org

[flackr, 2016-07-28 15:25:35]

lgtm

[majidvp, 2016-07-28 18:55:41]

On 2016/07/28 15:25:35, flackr wrote:
> lgtm

lgtml.

[majidvp, 2016-07-28 18:56:31]

> lgtml.

lgtm for real this time :)

[ikilpatrick, 2016-07-28 20:57:05]

Thanks all.

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
(right):

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp:21:
AnimationWorklet::AnimationWorklet(LocalFrame* frame, ExecutionContext*
executionContext)
On 2016/07/28 06:13:53, nhiroki wrote:
> |frame| is not necessary?

Done.

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h
(right):

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h:9:
#include "modules/worklet/ThreadedWorkletGlobalScopeProxy.h"
On 2016/07/28 06:13:53, nhiroki wrote:
> This is included in *.cpp, too.
> Maybe forward declaration can work.

Done. Originally so that workletGlobalScopeProxy() function could do conversion
to WorkletGlobalScopeProxy, not needed atm.

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h
(right):

https://codereview.chromium.org/2186203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h:33:
mutable Member<AnimationWorklet> m_animationWorklet;
On 2016/07/28 14:48:17, yhirano wrote:
> Why is this mutable? Can't we remove the const qualifier from
> |animationWorklet|?

Done, not sure why, I'll send a patch for paintworklet as well.

[ikilpatrick, 2016-07-28 20:57:31]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2016-07-28 20:57:31]

The patchset sent to the CQ was uploaded after l-g-t-m from flackr@chromium.org,
nhiroki@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2186203002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-07-28 20:58:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 23:51:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-28 23:53:11]

Description was changed from

==========
[worklets] Add stub classes for window.animationWorklet

This adds the code necessary just to return a Worklet object from the
window.animationWorklet attribute.

Followup patches will actually perform the wiring between this and
creating the background WorkerThread.

(Alternatively we could also start with audioWorklet as well, up to the
 reviewers; either or :).

BUG=567358
==========

to

==========
[worklets] Add stub classes for window.animationWorklet

This adds the code necessary just to return a Worklet object from the
window.animationWorklet attribute.

Followup patches will actually perform the wiring between this and
creating the background WorkerThread.

(Alternatively we could also start with audioWorklet as well, up to the
 reviewers; either or :).

BUG=567358

Committed: https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27
Cr-Commit-Position: refs/heads/master@{#408508}
==========

[commit-bot: I haz the power, 2016-07-28 23:53:12]

Patchset 3 (id:??) landed as
https://crrev.com/9febb56d38fc23e6f7e18f7a2886c2d5876a8a27
Cr-Commit-Position: refs/heads/master@{#408508}