Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2186153002: Removed unused TrayBarButtonWithTitle class. (Closed)

Created:
4 years, 4 months ago by bruthig
Modified:
4 years, 4 months ago
Reviewers:
James Cook, sadrul
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unused TrayBarButtonWithTitle class. BUG=None Committed: https://crrev.com/2b30faee222f7130b71f9da9fd8abea106207c03 Cr-Commit-Position: refs/heads/master@{#408641}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed IDR_SLIDER_ACTIVE_RIGHT resources. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -154 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ash/common/system/tray/tray_bar_button_with_title.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ash/common/system/tray/tray_bar_button_with_title.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D ui/views/resources/default_100_percent/slider_right_active.png View 1 Binary file 0 comments Download
D ui/views/resources/default_200_percent/slider_right_active.png View 1 Binary file 0 comments Download
M ui/views/resources/views_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
bruthig
James, can you PTAL?
4 years, 4 months ago (2016-07-27 20:49:40 UTC) #6
James Cook
https://codereview.chromium.org/2186153002/diff/1/ash/common/system/tray/tray_bar_button_with_title.cc File ash/common/system/tray/tray_bar_button_with_title.cc (left): https://codereview.chromium.org/2186153002/diff/1/ash/common/system/tray/tray_bar_button_with_title.cc#oldcode21 ash/common/system/tray/tray_bar_button_with_title.cc:21: IDR_SLIDER_ACTIVE_LEFT, IDR_SLIDER_ACTIVE_CENTER, IDR_SLIDER_ACTIVE_RIGHT, Are these resources used anywhere else? ...
4 years, 4 months ago (2016-07-27 20:53:17 UTC) #7
bruthig
https://codereview.chromium.org/2186153002/diff/1/ash/common/system/tray/tray_bar_button_with_title.cc File ash/common/system/tray/tray_bar_button_with_title.cc (left): https://codereview.chromium.org/2186153002/diff/1/ash/common/system/tray/tray_bar_button_with_title.cc#oldcode21 ash/common/system/tray/tray_bar_button_with_title.cc:21: IDR_SLIDER_ACTIVE_LEFT, IDR_SLIDER_ACTIVE_CENTER, IDR_SLIDER_ACTIVE_RIGHT, On 2016/07/27 20:53:17, James Cook wrote: ...
4 years, 4 months ago (2016-07-27 21:08:13 UTC) #9
James Cook
LGTM. Thanks for cleaning this up!
4 years, 4 months ago (2016-07-27 22:31:42 UTC) #13
bruthig
sadrul@, can you please review changes in ui/views/* ?
4 years, 4 months ago (2016-07-28 11:44:03 UTC) #15
sadrul
lgtm
4 years, 4 months ago (2016-07-29 14:34:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186153002/20001
4 years, 4 months ago (2016-07-29 14:47:02 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 15:25:11 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 15:26:16 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b30faee222f7130b71f9da9fd8abea106207c03
Cr-Commit-Position: refs/heads/master@{#408641}

Powered by Google App Engine
This is Rietveld 408576698