Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 2186143002: Tests for several SummaryDataStore and ResynthesizerResultProvider features. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tests for several SummaryDataStore and ResynthesizerResultProvider features. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/528b32d9971b3e8c6a4a7f46ce4597319c527405

Patch Set 1 #

Total comments: 1

Patch Set 2 : Actually add the new test file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -9 lines) Patch
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 3 chunks +9 lines, -9 lines 0 comments Download
A pkg/analyzer/test/src/summary/package_bundle_reader_test.dart View 1 1 chunk +229 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 4 months ago (2016-07-27 19:38:08 UTC) #1
Brian Wilkerson
https://codereview.chromium.org/2186143002/diff/1/pkg/analyzer/test/src/summary/test_all.dart File pkg/analyzer/test/src/summary/test_all.dart (right): https://codereview.chromium.org/2186143002/diff/1/pkg/analyzer/test/src/summary/test_all.dart#newcode16 pkg/analyzer/test/src/summary/test_all.dart:16: import 'package_bundle_reader_test.dart' as package_bundle_reader_test; I don't appear to have ...
4 years, 4 months ago (2016-07-27 19:53:01 UTC) #2
scheglov
Yes, just added it. PTAL
4 years, 4 months ago (2016-07-27 19:55:02 UTC) #3
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-07-27 19:56:50 UTC) #4
scheglov
4 years, 4 months ago (2016-07-27 19:58:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
528b32d9971b3e8c6a4a7f46ce4597319c527405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698