Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218613014: Add support for multiple base distance field sizes. (Closed)

Created:
6 years, 8 months ago by jvanverth1
Modified:
6 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add support for multiple base distance field sizes. This improves quality at higher point sizes. BUG=skia:2173 Committed: http://code.google.com/p/skia/source/detail?r=14030

Patch Set 1 #

Patch Set 2 : Add comment #

Patch Set 3 : Revert fontscaler #

Total comments: 4

Patch Set 4 : Fix issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jvanverth1
6 years, 8 months ago (2014-04-01 17:52:17 UTC) #1
robertphillips
lgtm modulo 2 questions https://codereview.chromium.org/218613014/diff/40001/src/gpu/GrDistanceFieldTextContext.cpp File src/gpu/GrDistanceFieldTextContext.cpp (right): https://codereview.chromium.org/218613014/diff/40001/src/gpu/GrDistanceFieldTextContext.cpp#newcode30 src/gpu/GrDistanceFieldTextContext.cpp:30: static const int kLargeDFFontSize = ...
6 years, 8 months ago (2014-04-01 17:55:43 UTC) #2
jvanverth1
https://codereview.chromium.org/218613014/diff/40001/src/gpu/GrDistanceFieldTextContext.cpp File src/gpu/GrDistanceFieldTextContext.cpp (right): https://codereview.chromium.org/218613014/diff/40001/src/gpu/GrDistanceFieldTextContext.cpp#newcode30 src/gpu/GrDistanceFieldTextContext.cpp:30: static const int kLargeDFFontSize = 128; On 2014/04/01 17:55:43, ...
6 years, 8 months ago (2014-04-01 18:06:06 UTC) #3
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 8 months ago (2014-04-02 17:46:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/218613014/50001
6 years, 8 months ago (2014-04-02 17:46:10 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 19:24:34 UTC) #6
Message was sent while issue was closed. 
Change committed as 14030

Powered by Google App Engine
This is Rietveld 408576698