Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Unified Diff: Source/devtools/front_end/SettingsScreen.js

Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments - take 1 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/SettingsScreen.js
diff --git a/Source/devtools/front_end/SettingsScreen.js b/Source/devtools/front_end/SettingsScreen.js
index 70a2de37204e9774707ab858a47fa3cdce588e16..ce0731aaaebdbf2482e4d1db4c7099a438931a4e 100644
--- a/Source/devtools/front_end/SettingsScreen.js
+++ b/Source/devtools/front_end/SettingsScreen.js
@@ -662,11 +662,13 @@ WebInspector.SettingsController.SettingsScreenActionDelegate = function() { }
WebInspector.SettingsController.SettingsScreenActionDelegate.prototype = {
/**
+ * @param {!WebInspector.Context} context
* @return {boolean}
*/
- handleAction: function()
+ handleAction: function(context)
{
- WebInspector.settingsController.showSettingsScreen(WebInspector.SettingsScreen.Tabs.General);
+ if (!context.flavor(WebInspector.Dialog))
+ WebInspector.settingsController.showSettingsScreen(WebInspector.SettingsScreen.Tabs.General);
return true;
}
}

Powered by Google App Engine
This is Rietveld 408576698