Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: Source/devtools/front_end/AdvancedSearchView.js

Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments - take 1 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/AdvancedSearchView.js
diff --git a/Source/devtools/front_end/AdvancedSearchView.js b/Source/devtools/front_end/AdvancedSearchView.js
index 9d39fb73a386742827bd8d3634330e106fe191f5..9a1afaf98b33da3cb5e020d915c5b1cc671f20c6 100644
--- a/Source/devtools/front_end/AdvancedSearchView.js
+++ b/Source/devtools/front_end/AdvancedSearchView.js
@@ -362,12 +362,12 @@ WebInspector.AdvancedSearchView.ToggleDrawerViewActionDelegate = function()
WebInspector.AdvancedSearchView.ToggleDrawerViewActionDelegate.prototype = {
/**
- * @param {!Event} event
+ * @param {!WebInspector.Context} context
* @return {boolean}
*/
- handleAction: function(event)
+ handleAction: function(context)
{
- if (WebInspector.Dialog.currentInstance())
+ if (context.flavor(WebInspector.Dialog))
pfeldman 2014/04/17 10:40:25 We should not make everything dialog-aware.
apavlov 2014/04/17 12:42:22 Done.
return false;
var searchView = this._searchView();
if (!searchView)

Powered by Google App Engine
This is Rietveld 408576698