Source/devtools/front_end/InspectorView.js - Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/InspectorView.js

Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments, handle Dialog key events in the glasspane keydown handler Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/InspectorView.js

diff --git a/Source/devtools/front_end/InspectorView.js b/Source/devtools/front_end/InspectorView.js

index f9abed168acb1d5dfae1fcb07ef3adcfd1b08c5f..68adb270f77e350905f624c907c8203abaa75c12 100644

--- a/Source/devtools/front_end/InspectorView.js

+++ b/Source/devtools/front_end/InspectorView.js

@@ -196,6 +196,8 @@ WebInspector.InspectorView.prototype = {

_tabSelected: function()

{

var panelName = this._tabbedPane.selectedTabId;

+ if (!panelName)

+ return;

var panel = this._panelDescriptors[this._tabbedPane.selectedTabId].panel();

this._tabbedPane.changeTabView(panelName, panel);

@@ -259,7 +261,7 @@ WebInspector.InspectorView.prototype = {

/**

- * @return {string}

+ * @return {?string}

selectedViewInDrawer: function()

{