Source/devtools/front_end/AdvancedSearchView.js - Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/AdvancedSearchView.js

Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments, handle Dialog key events in the glasspane keydown handler Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/AdvancedSearchView.js

diff --git a/Source/devtools/front_end/AdvancedSearchView.js b/Source/devtools/front_end/AdvancedSearchView.js

index 9d39fb73a386742827bd8d3634330e106fe191f5..0b5cbd3eca4b3f3c1dbbad3d93d6435de2590fd5 100644

--- a/Source/devtools/front_end/AdvancedSearchView.js

+++ b/Source/devtools/front_end/AdvancedSearchView.js

@@ -362,13 +362,11 @@ WebInspector.AdvancedSearchView.ToggleDrawerViewActionDelegate = function()

WebInspector.AdvancedSearchView.ToggleDrawerViewActionDelegate.prototype = {

/**

- * @param {!Event} event

+ * @param {!WebInspector.Context} context

* @return {boolean}

- handleAction: function(event)

+ handleAction: function(context)

{

- if (WebInspector.Dialog.currentInstance())

- return false;

var searchView = this._searchView();

if (!searchView)

return false;