Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: Source/devtools/front_end/SettingsScreen.js

Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments - take 1 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
655 } 655 }
656 656
657 /** 657 /**
658 * @constructor 658 * @constructor
659 * @implements {WebInspector.ActionDelegate} 659 * @implements {WebInspector.ActionDelegate}
660 */ 660 */
661 WebInspector.SettingsController.SettingsScreenActionDelegate = function() { } 661 WebInspector.SettingsController.SettingsScreenActionDelegate = function() { }
662 662
663 WebInspector.SettingsController.SettingsScreenActionDelegate.prototype = { 663 WebInspector.SettingsController.SettingsScreenActionDelegate.prototype = {
664 /** 664 /**
665 * @param {!WebInspector.Context} context
665 * @return {boolean} 666 * @return {boolean}
666 */ 667 */
667 handleAction: function() 668 handleAction: function(context)
668 { 669 {
669 WebInspector.settingsController.showSettingsScreen(WebInspector.Settings Screen.Tabs.General); 670 if (!context.flavor(WebInspector.Dialog))
671 WebInspector.settingsController.showSettingsScreen(WebInspector.Sett ingsScreen.Tabs.General);
670 return true; 672 return true;
671 } 673 }
672 } 674 }
673 675
674 /** 676 /**
675 * @constructor 677 * @constructor
676 * @extends {WebInspector.Object} 678 * @extends {WebInspector.Object}
677 * @param {function(!Element, string, ?string)} itemRenderer 679 * @param {function(!Element, string, ?string)} itemRenderer
678 */ 680 */
679 WebInspector.SettingsList = function(columns, itemRenderer) 681 WebInspector.SettingsList = function(columns, itemRenderer)
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
1053 var inputElement = this._addInputElements[columnId]; 1055 var inputElement = this._addInputElements[columnId];
1054 inputElement.value = ""; 1056 inputElement.value = "";
1055 } 1057 }
1056 }, 1058 },
1057 1059
1058 __proto__: WebInspector.SettingsList.prototype 1060 __proto__: WebInspector.SettingsList.prototype
1059 } 1061 }
1060 1062
1061 /** @type {!WebInspector.SettingsController} */ 1063 /** @type {!WebInspector.SettingsController} */
1062 WebInspector.settingsController; 1064 WebInspector.settingsController;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698