DevTools: Decouple shortcuts from actions, introduce shortcut contexts

Source/devtools/front_end/Main.js

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 311 matching lines @@
 
         new WebInspector.DebuggerScriptMapping(WebInspector.debuggerModel, WebInspector.workspace, WebInspector.networkWorkspaceBinding);
         WebInspector.liveEditSupport = new WebInspector.LiveEditSupport(WebInspector.workspace);
         new WebInspector.CSSStyleSheetMapping(WebInspector.cssModel, WebInspector.workspace, WebInspector.networkWorkspaceBinding);
         new WebInspector.PresentationConsoleMessageHelper(WebInspector.workspace);
 
         // Create settings before loading modules.
         WebInspector.settings.initializeBackendSettings();
 
         this._registerModules();
-        WebInspector.KeyboardShortcut.registerActions();
+        WebInspector.actionRegistry = new WebInspector.ActionRegistry();
+        WebInspector.KeyboardShortcut.registerBindings();
 
         WebInspector.panels = {};
         WebInspector.inspectorView = new WebInspector.InspectorView();
         // Screencast controller creates a root view itself.
         if (mainTarget.canScreencast)
             this._screencastController = new WebInspector.ScreencastController();
         else
             this._createRootView();
         this._createGlobalStatusBarItems();
 
@@ skipping 315 matching lines @@
 /**
  * @constructor
  * @implements {WebInspector.ActionDelegate}
  */
 WebInspector.Main.ReloadActionDelegate = function()
 {
 }
 
 WebInspector.Main.ReloadActionDelegate.prototype = {
     /**
+     * @param {!WebInspector.Context} context
      * @return {boolean}
      */
-    handleAction: function()
+    handleAction: function(context)
     {
-        if (!WebInspector.Dialog.currentInstance()) {
+        if (!context.flavor(WebInspector.Dialog)) {

[pfeldman, 2014/04/17 10:40:25]

We end up with everything checking for dialog, we can't afford this.

[apavlov, 2014/04/17 12:42:22]

Done.

             WebInspector.debuggerModel.skipAllPauses(true, true);
             WebInspector.resourceTreeModel.reloadPage(false);
         }
         return true;
     }
 }
 
 /**
  * @constructor
  * @implements {WebInspector.ActionDelegate}
  */
 WebInspector.Main.HardReloadActionDelegate = function()
 {
 }
 
 WebInspector.Main.HardReloadActionDelegate.prototype = {
     /**
+     * @param {!WebInspector.Context} context
      * @return {boolean}
      */
-    handleAction: function()
+    handleAction: function(context)
     {
-        if (!WebInspector.Dialog.currentInstance()) {
+        if (!context.flavor(WebInspector.Dialog)) {
             WebInspector.debuggerModel.skipAllPauses(true, true);
             WebInspector.resourceTreeModel.reloadPage(true);
         }
         return true;
     }
 }
 
 /**
  * @constructor
  * @implements {WebInspector.ActionDelegate}
@@ skipping 60 matching lines @@
 
 WebInspector.__defineGetter__("inspectedPageURL", function()
 {
     return WebInspector.resourceTreeModel.inspectedPageURL();
 });
 
 WebInspector.panel = function(name)
 {
     return WebInspector.inspectorView.panel(name);
 }