DevTools: Decouple shortcuts from actions, introduce shortcut contexts

Source/devtools/front_end/ActionRegistry.js

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @constructor
+ * @implements {WebInspector.ActionRegistryAPI}
+ */
+WebInspector.ActionRegistry = function()
+{
+    this._actionsById = new StringMap();
+}
+
+WebInspector.ActionRegistry.prototype = {

[pfeldman, 2014/04/10 09:35:45]

This is a too small step for me to assess if the direction is right.

+    registerActions: function()
+    {
+        WebInspector.moduleManager.extensions(WebInspector.ActionDelegate).forEach(registerExtension, this);

[pfeldman, 2014/04/14 13:10:44]

Do this from constructor instead?

[apavlov, 2014/04/15 13:33:14]

The registration step requires the ModuleManager to have loaded the modules. So
I will have to construct the ActionRegistry instance in Main.js rather than at
the end of this file. Does that sound good?

+
+        /**
+         * @param {!WebInspector.ModuleManager.Extension} extension
+         * @this {WebInspector.ActionRegistry}
+         */
+        function registerExtension(extension)
+        {
+            var actionId = extension.descriptor()["actionId"];
+            console.assert(actionId);
+            console.assert(!this._actionsById.get(actionId));
+            this._actionsById.put(actionId, extension);
+        }
+    },
+
+    /**
+     * @param {string} actionId
+     * @param {!Event} event
+     * @return {boolean}
+     */
+    execute: function(actionId, event)

[pfeldman, 2014/04/14 13:10:44]

You would want to expose actions for context here so that you could populate
context menus, etc.

[apavlov, 2014/04/15 13:33:14]

Done.

+    {
+        var extension = this._actionsById.get(actionId);
+        console.assert(extension, "No action found for actionId '" + actionId + "'");
+        return extension.instance().handleAction(event);
+    }
+}