Issue 218613012: Revert of Refactor perf bisect script _CalculateConfidence method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218613012: Revert of Refactor perf bisect script _CalculateConfidence method. (Closed)

Created:
6 years, 8 months ago by qyearsley

Modified:
6 years, 8 months ago

Reviewers:
prasadv, shatch

CC:
chromium-reviews, ghost stip (do not use)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of Refactor perf bisect script _CalculateConfidence method. (https://codereview.chromium.org/209853009/) Reason for revert: Caused issue 358622. The bug was that at line 2832 I used a tuple instead of a list, then later I tried to assign to a member of the tuple, but Python tuples are immutable. Original issue's description: > Refactor perf bisect script _CalculateConfidence method. > > - Adding docstrings > - Factoring out _CalculateBounds method > - Bug fix??? > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260241 TBR=prasadv@chromium.org,simonhatch@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260885