Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218613010: Mojo: Move mojo/public/bindings/*.h to mojo/public/cpp/bindings/*.h. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, creis+watch_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Move mojo/public/bindings/*.h to mojo/public/cpp/bindings/*.h. I'll do bindings/{lib,tests} separately. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1454 lines) Patch
M content/browser/renderer_host/render_process_host_mojo_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mojo/mojo_render_process_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/common_type_converters.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/common/common_type_converters_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/aura_demo/window_tree_host_mojo.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/aura_demo/window_tree_host_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/pepper_container_app/type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/sample_app/gles2_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/view_manager/view_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/gles2/gles2_context.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gypi View 2 chunks +11 lines, -11 lines 0 comments Download
D mojo/public/bindings/allocation_scope.h View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/public/bindings/array.h View 1 chunk +0 lines, -157 lines 0 comments Download
D mojo/public/bindings/buffer.h View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/public/bindings/callback.h View 1 chunk +0 lines, -461 lines 0 comments Download
D mojo/public/bindings/callback.h.pump View 1 chunk +0 lines, -79 lines 0 comments Download
D mojo/public/bindings/error_handler.h View 1 chunk +0 lines, -18 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +3 lines, -3 lines 0 comments Download
D mojo/public/bindings/interface.h View 1 chunk +0 lines, -92 lines 0 comments Download
M mojo/public/bindings/lib/DEPS View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/bindings/lib/array.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/array_internal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/bindings/lib/bindings_serialization.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/bindings/lib/buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/connector.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/fixed_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/message.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/message_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/message_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/scratch_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/sync_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/public/bindings/message.h View 1 chunk +0 lines, -112 lines 0 comments Download
D mojo/public/bindings/passable.h View 1 chunk +0 lines, -73 lines 0 comments Download
D mojo/public/bindings/remote_ptr.h View 1 chunk +0 lines, -156 lines 0 comments Download
D mojo/public/bindings/sync_dispatcher.h View 1 chunk +0 lines, -37 lines 0 comments Download
M mojo/public/bindings/tests/array_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/bindings/tests/buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/handle_passing_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/bindings/tests/remote_ptr_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/bindings/tests/request_response_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/bindings/tests/sample_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/tests/type_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/bindings/type_converter.h View 1 chunk +0 lines, -68 lines 0 comments Download
A mojo/public/cpp/bindings/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + mojo/public/cpp/bindings/allocation_scope.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/bindings/array.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/public/cpp/bindings/buffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/bindings/callback.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/bindings/callback.h.pump View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/bindings/error_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/bindings/interface.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/public/cpp/bindings/message.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/bindings/passable.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/bindings/remote_ptr.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/public/cpp/bindings/sync_dispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/cpp/bindings/type_converter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/shell/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/shell/application.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/shell/service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/service_manager/service_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/service_manager/service_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/gles2/command_buffer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/gles2/command_buffer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/gles2/command_buffer_type_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/native_viewport_service.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/app_child_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/app_child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/out_of_process_dynamic_service_runner.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-01 03:47:16 UTC) #1
darin (slow to review)
LGTM
6 years, 8 months ago (2014-04-01 06:47:29 UTC) #2
viettrungluu
6 years, 8 months ago (2014-04-01 14:49:21 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r260865 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698