Issue 218613002: Set kTruncatingToSmi for HChange only when To rep is Smi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218613002: Set kTruncatingToSmi for HChange only when To rep is Smi (Closed)

Created:
6 years, 8 months ago by Weiliang

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Set kTruncatingToSmi for HChange only when To rep is Smi BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20385

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/hydrogen-instructions.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	src/hydrogen-instructions.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Weiliang

On 2014/03/31 08:58:38, Toon Verwaest wrote: > lgtm Thanks Toon, Could you please help me ...

6 years, 8 months ago (2014-04-01 02:20:53 UTC) #3

Toon Verwaest

Committed patchset #1 manually as r20385 (presubmit successful).

6 years, 8 months ago (2014-04-01 10:32:34 UTC) #4

Weiliang

6 years, 8 months ago (2014-04-02 03:46:18 UTC) #5

Message was sent while issue was closed.

On 2014/04/01 10:32:34, Toon Verwaest wrote:
> Committed patchset #1 manually as r20385 (presubmit successful).

Glad to see there are ~5% performance improvement for both octane-crypto and
sunspider-crypto-md5 (http://www.arewefastyet.com/)

Expand Messages | Collapse Messages