Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2186113003: Require internal recipe tryjob (Closed)

Created:
4 years, 4 months ago by martiniss
Modified:
4 years, 4 months ago
Reviewers:
estaab, nodir, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M infra/config/cq.cfg View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
martiniss
PTAL
4 years, 4 months ago (2016-07-29 19:23:43 UTC) #3
estaab
lgtm
4 years, 4 months ago (2016-07-29 19:24:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186113003/1
4 years, 4 months ago (2016-08-09 22:47:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/4f9a9aa4b0b3da4c2eb8a5f0e2ee9837e0cf6012
4 years, 4 months ago (2016-08-09 22:51:20 UTC) #8
martiniss
4 years, 4 months ago (2016-08-10 18:38:30 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2235943002/ by martiniss@chromium.org.

The reason for reverting is: Roller needs to know about bypass reasons.

Powered by Google App Engine
This is Rietveld 408576698