Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2186103002: DEPS: sfntly 468cad5 → b18b09b (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DEPS: sfntly 468cad5 → b18b09b SfntlyWrapper::SubsetFont now takes TTC index, needed for SkPDF. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186103002 Committed: https://skia.googlesource.com/skia/+/95860ad4004e96f53485da49d0c2c91c50754206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
hal.canary
please rubberstamp
4 years, 4 months ago (2016-07-27 18:31:50 UTC) #5
bungeman-skia
rubberstamp lgtm applied
4 years, 4 months ago (2016-07-27 19:27:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186103002/1
4 years, 4 months ago (2016-07-27 19:28:02 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 19:28:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/95860ad4004e96f53485da49d0c2c91c50754206

Powered by Google App Engine
This is Rietveld 408576698